ci: migrate config - #36
Conversation
….json with updated formatting
- Remove invalid 'datasource' properties from conan and jsonnet-bundler - Remove deprecated 'branchName', 'commitMessage', and 'prTitle' properties - Remove 'timeout' from gradle config (only allowed in hostRules) - Fix trailing commas causing JSON syntax errors
# Conflicts: # .github/renovate.json
📝 WalkthroughSummary by CodeRabbit
WalkthroughSeven configuration properties are removed from the Renovate config file: Gradle timeout setting, datasource overrides for Conan and jsonnet-bundler package managers, and three root-level naming templates (commitMessage, prTitle, and branchName instances). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-02-14 to 2026-02-14 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
.github/renovate.json (4)
1-878: 🛠️ Refactor suggestion | 🟠 MajorMigrated config contains ~50+ manager defaults that are unnecessary and obscure intentional settings.
Only 6 managers are enabled (
enabledManagerson lines 10–17), yet the file explicitly defines configurations for dozens of unused managers (sbt, cargo, nix, terraform, docker, helm, etc.). This appears to be an artifact of the migration tool dumping all Renovate defaults.This creates a significant maintenance burden — it's nearly impossible to distinguish intentional overrides from default values. Consider stripping the file down to only the settings that differ from Renovate's built-in defaults and the presets you already extend (e.g.,
config:best-practices).
126-126:⚠️ Potential issue | 🟡 MinorEmpty
"versioning": ""is likely a migration artifact — remove it.An empty string here overrides the default versioning strategy with nothing, which may cause unexpected behavior. If no custom versioning is needed at the global level, this key should be removed entirely so Renovate uses its per-datasource defaults.
422-422: 🧹 Nitpick | 🔵 Trivial
"configMigration": falsewill prevent Renovate from auto-fixing future deprecated options.Consider setting this to
trueso Renovate can propose PRs to keep this config file valid as options evolve — especially given the large surface area of explicit settings in this file.
226-226:⚠️ Potential issue | 🟠 MajorRemove
"bumpVersion": "major"— this was added during the migration and wasn't in the previous config.This root-level setting tells Renovate to bump your project's own version by a major increment whenever it creates a dependency update PR. Unless intentionally configured, this will cause uncontrolled major version bumps and should be removed.
Location
.github/renovate.json, line 226
This pull request makes several clean-up changes to the
.github/renovate.jsonconfiguration file, removing unused or redundant settings and simplifying some manager definitions. The main focus is on eliminating unnecessary keys and streamlining configuration for dependency management tools.Configuration clean-up:
timeoutsetting from the Gradle manager configuration, as it is either unused or handled elsewhere.datasourcekey from the Conan manager configuration, simplifying its definition.commitMessagetemplate andbranchNametemplate from the global configuration, reducing complexity and reliance on custom message formats. [1] [2]jsonnet-bundlermanager configuration by removing thedatasourcekey and ensuring only relevant file patterns are specified.