Skip to content

feat: treat markdown content in overview text better #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rozPierog wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: treat markdown content in overview text better #1193

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2864f50
feat: render HTML content in overview text
rozPierog Apr 3, 2026
6ddaa2f
feat: improve markdown and HTML handling in item overviews
rozPierog Apr 10, 2026
57cd3b8
Merge branch 'main' into leon/respect-html-in-overview
rozPierog Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/com/github/damontecres/wholphin/ui/components/OverviewText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.fromHtml
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
Expand Down Expand Up @@ -59,7 +61,7 @@ fun OverviewText(
},
) {
Text(
text = overview,
text = AnnotatedString.fromHtml(overview),
style = MaterialTheme.typography.bodyMedium,
color = MaterialTheme.colorScheme.onSurface,
maxLines = maxLines,
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/com/github/damontecres/wholphin/ui/data/ItemDetailsDialogInfo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.fromHtml
import androidx.compose.ui.unit.dp
import androidx.tv.material3.MaterialTheme
import androidx.tv.material3.Text
Expand Down Expand Up @@ -82,7 +84,7 @@ fun ItemDetailsDialog(
}
if (info.overview.isNotNullOrBlank()) {
Text(
text = info.overview,
text = AnnotatedString.fromHtml(info.overview),
style = MaterialTheme.typography.bodyMedium,
)
}
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/github/damontecres/wholphin/ui/main/HomePage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.fromHtml
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
Expand Down Expand Up @@ -500,7 +501,7 @@ fun HomePageHeader(
.width(400.dp)
if (overview.isNotNullOrBlank()) {
Text(
text = overview,
text = AnnotatedString.fromHtml(overview),
style = MaterialTheme.typography.bodyMedium,
color = MaterialTheme.colorScheme.onSurface,
maxLines = if (overviewTwoLines) 2 else 3,
Expand Down
Loading