Skip to content

Add NDCI to spectral indices supported #1714

Merged
nfahlgren merged 4 commits into
mainfrom
add-ndci
Jun 9, 2025
Merged

Add NDCI to spectral indices supported #1714
nfahlgren merged 4 commits into
mainfrom
add-ndci

Conversation

@HaleySchuhl

Copy link
Copy Markdown
Contributor

Describe your changes
Adds NDCI to pcv.spectral_index subpackage

Type of update
Is this a:

  • New feature

Associated issues

Additional context
Useful for quantifying chlorophyll-a

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the new feature New feature ideas and solutions label Jun 5, 2025
@deepsource-io

deepsource-io Bot commented Jun 5, 2025

Copy link
Copy Markdown

Here's the code health analysis summary for commits 654a45b..1c5a64a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Comment thread docs/spectral_index.md
@nfahlgren nfahlgren added this to the PlantCV v4.8 milestone Jun 6, 2025
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 Jun 6, 2025
@nfahlgren nfahlgren merged commit bd8b218 into main Jun 9, 2025
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Requests to Done in PlantCV4 Jun 9, 2025
@nfahlgren nfahlgren deleted the add-ndci branch June 9, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature ideas and solutions ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add NDCI to spectral indices

2 participants