Skip to content

Create a logical operation helper function#1715

Merged
nfahlgren merged 7 commits into
mainfrom
logical-helpers
Jun 13, 2025
Merged

Create a logical operation helper function#1715
nfahlgren merged 7 commits into
mainfrom
logical-helpers

Conversation

@nfahlgren

@nfahlgren nfahlgren commented Jun 7, 2025

Copy link
Copy Markdown
Member

Describe your changes
To reduce the potential for circular imports, this PR adds a helper function for logical (and, or, xor) operations and replaces existing cross-plantcv imports with the helper.

Type of update
Is this a: code cleanup

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.8 milestone Jun 7, 2025
@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jun 7, 2025
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 Jun 7, 2025
@deepsource-io

deepsource-io Bot commented Jun 7, 2025

Copy link
Copy Markdown

Here's the code health analysis summary for commits 00788ec..871cb98. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review June 13, 2025 14:17
update comment to give xor context instead of "and"
@nfahlgren nfahlgren merged commit 6e23e95 into main Jun 13, 2025
5 checks passed
@nfahlgren nfahlgren deleted the logical-helpers branch June 13, 2025 15:11
@github-project-automation github-project-automation Bot moved this from Pull Requests to Done in PlantCV4 Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants