Skip to content

Reduce cyclomatic complexity readbayer#1723

Merged
nfahlgren merged 6 commits into
mainfrom
reduce-cyclomatic-complexity-readbayer
Jun 24, 2025
Merged

Reduce cyclomatic complexity readbayer#1723
nfahlgren merged 6 commits into
mainfrom
reduce-cyclomatic-complexity-readbayer

Conversation

@nfahlgren

@nfahlgren nfahlgren commented Jun 21, 2025

Copy link
Copy Markdown
Member

Describe your changes
Restructures the pcv.readbayer function to reduce cyclomatic complexity.

Type of update
Is this a: code cleanup

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.8 milestone Jun 21, 2025
@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jun 21, 2025
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 Jun 21, 2025
@deepsource-io

deepsource-io Bot commented Jun 21, 2025

Copy link
Copy Markdown

Here's the code health analysis summary for commits 034bbea..f171472. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nfahlgren nfahlgren merged commit 22bc25e into main Jun 24, 2025
5 checks passed
@nfahlgren nfahlgren deleted the reduce-cyclomatic-complexity-readbayer branch June 24, 2025 21:07
@github-project-automation github-project-automation Bot moved this from Pull Requests to Done in PlantCV4 Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants