Skip to content

fix: persist PlexServerURL to config during --install #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielewood wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −13
Open

fix: persist PlexServerURL to config during --install #28

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a93d918
fix: persist PlexServerURL to config during --install
danielewood Mar 22, 2026
fef8e8e
fix: quote PlexServerURL value in config to prevent shell injection
danielewood Mar 23, 2026
5f23477
fix: write shell-safe config values
danielewood Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions plexargod.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ RestartSec=5s
[Install]
WantedBy=multi-user.target
UNIT
mkdir -p /etc/plexargod
if [ ! -f /etc/plexargod/plexargod.conf ]; then
echo "# /etc/plexargod/plexargod.conf" > /etc/plexargod/plexargod.conf
fi
if grep -q "^PlexServerURL=" /etc/plexargod/plexargod.conf 2>/dev/null; then
sed -i "s|^PlexServerURL=.*|PlexServerURL=${PLEX_URL}|" /etc/plexargod/plexargod.conf
else
echo "PlexServerURL=${PLEX_URL}" >> /etc/plexargod/plexargod.conf

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Quote PlexServerURL before persisting it to sourced config

When --install is run with a URL containing shell metacharacters (for example $(...), backticks, or & in a query string), these lines write it verbatim into /etc/plexargod/plexargod.conf. Later the script does source "${plexargod_conf}" at plexargod.sh:100-102, so Bash evaluates that text as code/root shell syntax instead of loading it as data. At minimum this breaks legitimate URLs with &, and in the worst case it allows unintended command execution the next time plexargod runs.

Useful? React with 👍 / 👎.

fi
systemctl daemon-reload
systemctl enable plexargod
echo "plexargod.service installed and enabled."
Expand Down