Fix --purge-offline-worker-metrics - #383
Merged
Merged
Conversation
adinhodovic
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this PR fixes the
--purge-offline-worker-metricsissue described at #362 so a lateworker-offlineevent does not recreate a purged worker metric.The bug could happen in this sequence:
worker-offlineevent arrives for the same hostname.track_worker_status()recreatedcelery_worker_up{hostname="old-worker"} 0.0.worker_last_seen, the recreated zero-valued series was no longer eligible for future purge.Now only online events directly create/update
celery_worker_up. Offline events go throughforget_worker(), which already no-ops for unknown or already-purged workers.Note: AI assistance was used during investigation and validation.