Skip to content

Simplify CI: drop deploy workflow and per-service test matrices#3

Merged
dantraynor merged 1 commit into
mainfrom
dantraynor/review-tests
Apr 25, 2026
Merged

Simplify CI: drop deploy workflow and per-service test matrices#3
dantraynor merged 1 commit into
mainfrom
dantraynor/review-tests

Conversation

@dantraynor

@dantraynor dantraynor commented Apr 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Delete .github/workflows/deploy.yml (GCP/GCE deploy is irrelevant for an example repo).
  • Collapse ci.yml to two jobs: gitleaks and a single docker compose build that compiles every service.

Test Plan

  • make doctor
  • make test
  • Dashboard checked, if UI changed

Safety Impact

  • No execution behavior changed
  • Dry-run behavior reviewed
  • Kill-switch behavior reviewed
  • Risk limits reviewed

Notes

CI no longer runs unit tests; the docker build proves compilation. Add a focused test job back if test signal is wanted. No operator action required.

Drop the GCP deploy workflow and the per-service Rust/TS test matrices.
The example repo doesn't need a real deploy target, and docker compose
build covers compilation across every service in one job.
Copilot AI review requested due to automatic review settings April 25, 2026 05:32
@dantraynor dantraynor merged commit 29a343b into main Apr 25, 2026
4 checks passed
@dantraynor dantraynor deleted the dantraynor/review-tests branch April 25, 2026 05:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies GitHub Actions for the repo by removing the GCP/GCE deployment workflow and reducing CI to secret scanning plus a single Docker Compose build that compiles/builds all services as container images.

Changes:

  • Removed .github/workflows/deploy.yml (no more automated image push + GCE deploy on main).
  • Collapsed .github/workflows/ci.yml into two jobs: gitleaks and a single docker compose ... build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/deploy.yml Removes the CI/CD deployment pipeline to GCP Artifact Registry + GCE.
.github/workflows/ci.yml Replaces per-service build/test matrices with a single docker compose build plus gitleaks scanning.
Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:26

  • This workflow no longer runs any unit/integration tests (previously cargo test and npm test per-service). docker compose ... build only proves images can build, and will miss failing tests/regressions that currently exist in the repo (e.g., Jest suites under strategy services). Consider adding a dedicated test job back (even a minimal make test, or cargo test for Rust + npm test for the key services) so CI still enforces behavior, not just compilation.
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Build all images
        run: docker compose -f docker-compose.yml -f docker-compose.dev.yml build

.github/workflows/ci.yml:26

  • By removing the deploy workflow, the repo's operator/deployment docs become misleading (e.g., README mentions “GitHub Actions deployment” and docs/DEPLOY_RUNBOOK.md lists GitHub Actions secrets like GCE_INSTANCE_IP/GCP_SA_KEY). If this repo is now intended to be “example-only”, consider updating/removing those docs (or adding a short note pointing to manual deployment) so contributors don’t follow a CI/CD path that no longer exists.
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Build all images
        run: docker compose -f docker-compose.yml -f docker-compose.dev.yml build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants