Simplify CI: drop deploy workflow and per-service test matrices#3
Merged
Conversation
Drop the GCP deploy workflow and the per-service Rust/TS test matrices. The example repo doesn't need a real deploy target, and docker compose build covers compilation across every service in one job.
There was a problem hiding this comment.
Pull request overview
This PR simplifies GitHub Actions for the repo by removing the GCP/GCE deployment workflow and reducing CI to secret scanning plus a single Docker Compose build that compiles/builds all services as container images.
Changes:
- Removed
.github/workflows/deploy.yml(no more automated image push + GCE deploy onmain). - Collapsed
.github/workflows/ci.ymlinto two jobs:gitleaksand a singledocker compose ... build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Removes the CI/CD deployment pipeline to GCP Artifact Registry + GCE. |
.github/workflows/ci.yml |
Replaces per-service build/test matrices with a single docker compose build plus gitleaks scanning. |
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:26
- This workflow no longer runs any unit/integration tests (previously
cargo testandnpm testper-service).docker compose ... buildonly proves images can build, and will miss failing tests/regressions that currently exist in the repo (e.g., Jest suites under strategy services). Consider adding a dedicated test job back (even a minimalmake test, orcargo testfor Rust +npm testfor the key services) so CI still enforces behavior, not just compilation.
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Build all images
run: docker compose -f docker-compose.yml -f docker-compose.dev.yml build
.github/workflows/ci.yml:26
- By removing the deploy workflow, the repo's operator/deployment docs become misleading (e.g., README mentions “GitHub Actions deployment” and
docs/DEPLOY_RUNBOOK.mdlists GitHub Actions secrets likeGCE_INSTANCE_IP/GCP_SA_KEY). If this repo is now intended to be “example-only”, consider updating/removing those docs (or adding a short note pointing to manual deployment) so contributors don’t follow a CI/CD path that no longer exists.
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Build all images
run: docker compose -f docker-compose.yml -f docker-compose.dev.yml build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/deploy.yml(GCP/GCE deploy is irrelevant for an example repo).ci.ymlto two jobs:gitleaksand a singledocker compose buildthat compiles every service.Test Plan
make doctormake testSafety Impact
Notes
CI no longer runs unit tests; the docker build proves compilation. Add a focused test job back if test signal is wanted. No operator action required.