Skip to content

DAOS-19103 test: call FI macro in rebuild tests#18472

Open
kccain wants to merge 1 commit into
masterfrom
kccain/daos_19103
Open

DAOS-19103 test: call FI macro in rebuild tests#18472
kccain wants to merge 1 commit into
masterfrom
kccain/daos_19103

Conversation

@kccain

@kccain kccain commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This change covers DAOS-19103 and DAOS-19104 fixes needed
for the relevant interactive and simple rebuild test cases.

Add FAULT_INJECTION_REQUIRED() in tests requiring fault injection
enabled, to skip cleanly (instead of hange) when run with a daos
release build.

faults-enabled: false
Test-tag: test_daos_rebuild_simple test_daos_rebuild_interactive
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_rebuild_interactive- test timeout wait until rebuild starts erroring'
Status is 'In Progress'
Labels: '2.8.0rc1,pr_test'
https://daosio.atlassian.net/browse/DAOS-19103

@kccain kccain marked this pull request as ready for review June 9, 2026 21:21
@kccain kccain requested review from liuxuezhao and wangshilong June 9, 2026 21:21
wangshilong
wangshilong previously approved these changes Jun 10, 2026

@wangshilong wangshilong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better push all other fault injection requirement rebuild test as well.

@kccain

kccain commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

probably better push all other fault injection requirement rebuild test as well.

@wangshilong - agreed, I can update this patch with the daos_rebuild_simple.c cases that also need the macro invocation

@kccain kccain force-pushed the kccain/daos_19103 branch from b247949 to 64410ce Compare June 10, 2026 02:28
@kccain kccain changed the title DAOS-19103 test: call FI macro in interactive rebuild test DAOS-19103 test: call FI macro in rebuild tests Jun 10, 2026

@wangshilong wangshilong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This change covers DAOS-19103 and DAOS-19104 fixes needed
for the relevant interactive and simple rebuild test cases.

Add FAULT_INJECTION_REQUIRED() in tests requiring fault injection
enabled, to skip cleanly (instead of hange) when run with a daos
release build.

faults-enabled:  false
Test-tag: test_daos_rebuild_simple test_daos_rebuild_interactive
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@kccain kccain force-pushed the kccain/daos_19103 branch from 64410ce to f089d53 Compare June 10, 2026 02:43
@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 11, 2026
@kccain kccain requested a review from knard38 June 11, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

4 participants