DAOS-19103 test: call FI macro in rebuild tests#18472
Open
kccain wants to merge 1 commit into
Open
Conversation
|
Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_rebuild_interactive- test timeout wait until rebuild starts erroring' |
wangshilong
previously approved these changes
Jun 10, 2026
wangshilong
left a comment
Contributor
There was a problem hiding this comment.
probably better push all other fault injection requirement rebuild test as well.
Contributor
Author
@wangshilong - agreed, I can update this patch with the daos_rebuild_simple.c cases that also need the macro invocation |
b247949 to
64410ce
Compare
This change covers DAOS-19103 and DAOS-19104 fixes needed for the relevant interactive and simple rebuild test cases. Add FAULT_INJECTION_REQUIRED() in tests requiring fault injection enabled, to skip cleanly (instead of hange) when run with a daos release build. faults-enabled: false Test-tag: test_daos_rebuild_simple test_daos_rebuild_interactive Skip-unit-tests: true Skip-fault-injection-test: true Skip-test-rpms: true Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
64410ce to
f089d53
Compare
liuxuezhao
approved these changes
Jun 12, 2026
knard38
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change covers DAOS-19103 and DAOS-19104 fixes needed
for the relevant interactive and simple rebuild test cases.
Add FAULT_INJECTION_REQUIRED() in tests requiring fault injection
enabled, to skip cleanly (instead of hange) when run with a daos
release build.
faults-enabled: false
Test-tag: test_daos_rebuild_simple test_daos_rebuild_interactive
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-test-rpms: true
Steps for the author:
After all prior steps are complete: