Skip to content

SRE-3833 ci: remove obsolete code#18473

Open
grom72 wants to merge 1 commit into
masterfrom
grom72/SRE-3833
Open

SRE-3833 ci: remove obsolete code#18473
grom72 wants to merge 1 commit into
masterfrom
grom72/SRE-3833

Conversation

@grom72

@grom72 grom72 commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

discoverGitReferenceBuild is useless in the Jenkinsfile context and has no effect on build results.
It is called from inside unitTestPost.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@grom72
SRE-3833 ci: remove obsolete code
f4914cd 
discoverGitReferenceBuild is useless in the Jenkinsfile context
and has no effect on build results.
It is called from inside unitTestPost.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Priority: 2
Cancel-prev-build: false
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-func-vm-all: true
Skip-test-el-9-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-hw-test: true
Skip-func-test-el9: true
Skip-func-test-leap15: true
Skip-test-el-8-rpms: true
Skip-func-hw-test: true
Skip-func-test-el8: true
@grom72 grom72 marked this pull request as ready for review June 9, 2026 20:53
@grom72 grom72 requested a review from a team as a code owner June 9, 2026 20:53
@grom72 grom72 requested review from janekmi and phender June 9, 2026 20:54
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3833

JohnMalmberg
JohnMalmberg approved these changes Jun 10, 2026
View reviewed changes

@JohnMalmberg JohnMalmberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to take your word for it being obsolete, as I have no idea what it was used for.

daltonbohning
daltonbohning approved these changes Jun 10, 2026
View reviewed changes

@daltonbohning daltonbohning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the way that code was supposed to work is that Fault Injection will only complain about NEW issues that do not also show up in master. But if master is "clean" that maybe it does not matter. Anyway, we can always add this back in if it's an issue

@grom72 grom72 requested a review from a team June 11, 2026 06:32
@grom72

grom72 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I thought the way that code was supposed to work is that Fault Injection will only complain about NEW issues that do not also show up in master. But if master is "clean" that maybe it does not matter. Anyway, we can always add this back in if it's an issue

This code is triggered internally by the unitTestPost procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekmi janekmi janekmi approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@JohnMalmberg JohnMalmberg JohnMalmberg approved these changes

@phender phender Awaiting requested review from phender

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grom72 @janekmi @daltonbohning @JohnMalmberg