This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Add tests to free-calls pallet#189
Open
TarekkMA wants to merge 4 commits intodappforce:feature/free-callsfrom
Open
Add tests to free-calls pallet#189TarekkMA wants to merge 4 commits intodappforce:feature/free-callsfrom
TarekkMA wants to merge 4 commits intodappforce:feature/free-callsfrom
Conversation
Closed
TarekkMA
force-pushed
the
tarekkma/free-calls2-tests
branch
2 times, most recently
from
abdeec1 to
4fb7cf6
Compare
F3Joule
force-pushed
the
feature/free-calls
branch
from
aa3897f to
9bc4338
Compare
TarekkMA
force-pushed
the
tarekkma/free-calls2-tests
branch
3 times, most recently
from
e2018ab to
a8a8e8e
Compare
TarekkMA
force-pushed
the
tarekkma/free-calls2-tests
branch
2 times, most recently
from
2207e34 to
bccb44a
Compare
TarekkMA
force-pushed
the
tarekkma/free-calls2-tests
branch
from
bccb44a to
4841313
Compare
F3Joule
suggested changes
May 3, 2022
Member
F3Joule
left a comment
F3Joule
left a comment
There was a problem hiding this comment.
Resolve all "unused" related to tests here and all other unused in another PR.
Comment on lines
+84
to
+89
| #[pallet::weight(12_345)] | ||
| pub fn call_c(origin: OriginFor<T>) -> DispatchResult { | ||
| let _who = ensure_signed(origin)?; | ||
|
|
||
| Ok(()) | ||
| } |
| mod test_pallet; | ||
|
|
||
| #[cfg(test)] | ||
| mod tests; |
Member
There was a problem hiding this comment.
Looks like config validation function is not covered with tests:
https://github.com/dappforce/subsocial-node/blob/430fe055892bfdda1b328af81b5f9792a2ee559d/pallets/free-calls/src/config.rs#L72
| } | ||
| } | ||
|
|
||
| impl ExtBuilder { |
Member
There was a problem hiding this comment.
Include a test scenario, where we'll use this function:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #208 first