Skip to content

ethForward: check ETH/IPFS availability and drop ropsten support#2422

Open
3alpha wants to merge 3 commits intodevelopfrom
feature/ethforward-api-availability-mainnet-only
Open

ethForward: check ETH/IPFS availability and drop ropsten support#2422
3alpha wants to merge 3 commits intodevelopfrom
feature/ethforward-api-availability-mainnet-only

Conversation

@3alpha
Copy link
Copy Markdown
Member

@3alpha 3alpha commented Apr 17, 2026

Summary

Enhances the ethForward middleware to fail fast with clear user-facing messages when required services are unavailable, and removes legacy ropsten handling from the module.

What Changed

  • Added preflight availability checks before proxying for:
    • Ethereum JSON-RPC API
    • IPFS API
  • Added friendly HTML responses when ETH, IPFS, or both are unavailable.
  • Reused existing ethForward error handling paths and improved mapping for proxy/ETH connectivity failures.
  • Replaced duplicated ETH RPC hardcoded usage in-module with a shared mainnet constant.
  • Removed ropsten support from ethForward:
    • network typing is now mainnet-only
    • removed ropsten/.test resolution paths
    • removed ropsten view helpers and references

User-Facing Behavior

  • If ETH or IPFS is unavailable, ethForward now returns a clear page indicating:
    This feature is only available when running both IPFS and Ethereum nodes.

Scope

  • Only ethForward-related files were modified.

Validation

  • Verified no diagnostics errors in modified ethForward files via editor checks.

@3alpha 3alpha requested a review from a team as a code owner April 17, 2026 07:49
@github-actions github-actions Bot temporarily deployed to commit April 17, 2026 07:50 Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

@github-actions github-actions Bot temporarily deployed to commit April 17, 2026 07:58 Inactive
@3alpha 3alpha force-pushed the feature/ethforward-api-availability-mainnet-only branch from 403c715 to 4ee88f4 Compare April 21, 2026 15:14
@github-actions github-actions Bot temporarily deployed to commit April 21, 2026 15:15 Inactive
@Pol-Lanski
Copy link
Copy Markdown
Member

Pol-Lanski commented Apr 22, 2026

oh oh... bad news.

Installed:
dappmanager.dnp.dappnode.eth: 0.2.71, branch: feature/ethforward-api-availability-mainnet-only, commit: 403c715

In a machine that does NOT have full ETH node.

Tests:
vitalik.eth -> works
cowswap.eth -> it forwards me to https://about.ipfs.io/

Screenshot 2026-04-22 at 14 57 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants