Skip to content

Add persistCoreSettings function to manage core environment variables#2429

Open
pablomendezroyo wants to merge 2 commits intodevelopfrom
pablo/edit-core-on-disablescripts
Open

Add persistCoreSettings function to manage core environment variables#2429
pablomendezroyo wants to merge 2 commits intodevelopfrom
pablo/edit-core-on-disablescripts

Conversation

@pablomendezroyo
Copy link
Copy Markdown
Contributor

Context

This pull request introduces the persistCoreSettings function to ensure critical core environment variables and volume paths are preserved during updates. It enhances the management of core settings by propagating necessary values from the currently installed dappmanager compose.

Approach

The solution reads environment variables from the installed dappmanager compose and applies them to the new core compose services, ensuring that essential settings like DISABLE_HOST_SCRIPTS and volume mappings are correctly maintained.

Test instructions

  1. Update the core package and verify that the DISABLE_HOST_SCRIPTS environment variable is correctly set in the core compose.
  2. Check that the volume path for /usr/src/dappnode/ matches the DAPPNODE_CORE_DIR from the installed dappmanager compose.
  3. Test with different configurations to ensure that the settings persist as expected across updates.

@pablomendezroyo pablomendezroyo requested a review from a team as a code owner April 24, 2026 07:45
@github-actions github-actions Bot temporarily deployed to commit April 24, 2026 07:47 Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

@github-actions github-actions Bot temporarily deployed to commit April 24, 2026 08:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant