Skip to content

[DAQ] Decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit)#125

Draft
amotl wants to merge 4 commits into
mainfrom
daq-fineoffset
Draft

[DAQ] Decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit)#125
amotl wants to merge 4 commits into
mainfrom
daq-fineoffset

Conversation

@amotl

@amotl amotl commented Mar 1, 2023

Copy link
Copy Markdown
Member

Dear all,

originally coming from GH-123, this patch brings in a more solid implementation for acquiring measurement data from weather stations manufactured by Fine Offset Electronics, based on the excellent ecowitt2mqtt program.

With kind regards,
Andreas.

Details

The hardware is produced by Shenzhen Fine Offset Electronics Co., Ltd. (FOSHK) aka. Fine Offset aka. OFFSET. This includes brands that white-label Fine Offset equipment, such as:

  • Ambient Weather (U.S.)
  • Ecowitt (China, Hong Kong)
  • Froggit (Germany)

References

Backlog

  • Add software tests
  • Add documentation

@amotl amotl force-pushed the daq-fineoffset branch 2 times, most recently from 14b023a to a80d36a Compare March 1, 2023 19:59
@codecov

codecov Bot commented Mar 1, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.74%. Comparing base (ffa5011) to head (708c1dc).

Files with missing lines Patch % Lines
kotori/daq/decoder/fineoffset.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   78.53%   78.74%   +0.21%     
==========================================
  Files          56       57       +1     
  Lines        3024     3054      +30     
==========================================
+ Hits         2375     2405      +30     
  Misses        649      649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amotl amotl changed the title DAQ: Add decoder for Fine Offset (FOSHK) weather station equipment DAQ: Add decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit) Feb 10, 2026
@amotl amotl changed the title DAQ: Add decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit) [DAQ] Decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit) Feb 10, 2026
@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch daq-fineoffset

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl force-pushed the daq-fineoffset branch 3 times, most recently from 2e10df3 to 1cc6abe Compare February 12, 2026 05:42
amotl and others added 3 commits February 14, 2026 21:18
Through the excellent `ecowitt2mqtt` machinery [1], this supports any
weather station/gateway that is produced by Shenzhen Fine Offset
Electronics Co., Ltd. [2] aka. Fine Offset aka. OFFSET. This includes
brands that white-label Fine Offset equipment, such as:

- Ambient Weather (U.S.)
- Ecowitt (China, Hong Kong)
- Froggit (Germany)

By default, `ecowitt2mqtt` is configured to output data in the "metric"
unit system.

[1] https://github.com/bachya/ecowitt2mqtt
[2] https://www.foshk.com/
WARNING: kotori 0.0.0 does not provide the extra 'daq-fineoffset'
WARNING: kotori 0.0.0 does not provide the extra 'daq-geospatial'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant