[DAQ] Decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit)#125
Draft
amotl wants to merge 4 commits into
Draft
[DAQ] Decoder for Fine Offset (FOSHK) weather station equipment (Ambient Weather, Ecowitt, Froggit)#125amotl wants to merge 4 commits into
amotl wants to merge 4 commits into
Conversation
14b023a to
a80d36a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 78.53% 78.74% +0.21%
==========================================
Files 56 57 +1
Lines 3024 3054 +30
==========================================
+ Hits 2375 2405 +30
Misses 649 649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 2, 2023
1391232 to
7880420
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
2e10df3 to
1cc6abe
Compare
Through the excellent `ecowitt2mqtt` machinery [1], this supports any weather station/gateway that is produced by Shenzhen Fine Offset Electronics Co., Ltd. [2] aka. Fine Offset aka. OFFSET. This includes brands that white-label Fine Offset equipment, such as: - Ambient Weather (U.S.) - Ecowitt (China, Hong Kong) - Froggit (Germany) By default, `ecowitt2mqtt` is configured to output data in the "metric" unit system. [1] https://github.com/bachya/ecowitt2mqtt [2] https://www.foshk.com/
WARNING: kotori 0.0.0 does not provide the extra 'daq-fineoffset' WARNING: kotori 0.0.0 does not provide the extra 'daq-geospatial'
6411205 to
708c1dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
originally coming from GH-123, this patch brings in a more solid implementation for acquiring measurement data from weather stations manufactured by Fine Offset Electronics, based on the excellent ecowitt2mqtt program.
With kind regards,
Andreas.
Details
References
Backlog