[DRAFT] Add decoder for acquiring data in NDJSON format#129
Draft
amotl wants to merge 1 commit into
Draft
Conversation
3011c2a to
bef0e8b
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
cba1ce2 to
b2ab31f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bulk-json-compact #129 +/- ##
=====================================================
+ Coverage 78.70% 78.79% +0.09%
=====================================================
Files 57 58 +1
Lines 3062 3075 +13
=====================================================
+ Hits 2410 2423 +13
Misses 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amotl
commented
Feb 13, 2026
Comment on lines
+31
to
+41
| @staticmethod | ||
| def decode(payload): | ||
|
|
||
| # Decode from NDJSON, using pandas. | ||
| import io | ||
| import pandas as pd | ||
| df = pd.read_json(io.StringIO(payload), lines=True) | ||
|
|
||
| # Transform to records again. | ||
| data = df.to_dict(orient="records") | ||
| return data |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
this adds a decoder for NDJSON payloads. NDJSON is the Newline Delimited JSON format, and it is suitable for encoding/transmitting multiple JSON records in bulk, or for streaming them.
The standard JSON variant implemented with GH-40 is not really suitable for submitting data from embedded devices, because wrapping up multiple JSON records into an array will probably blow up your memory quickly.
NDJSON has been called LDJSON before being reasonably specified, and has also been known as JSON Lines, see also JSON streaming. It looks like this:
{"temperature":21.42,"humidity":41.55} {"temperature":42.84,"humidity":83.1}With kind regards,
Andreas.
/cc @Tonkenfo, @wetterfrosch, @msweef, @elektra42