Skip to content

Fix CI failing for Linux static analysis (unstable) & macOS homebrew#784

Merged
LebedevRI merged 2 commits intodarktable-org:developfrom
mlouielu:fix-ci
Mar 21, 2025
Merged

Fix CI failing for Linux static analysis (unstable) & macOS homebrew#784
LebedevRI merged 2 commits intodarktable-org:developfrom
mlouielu:fix-ci

Conversation

@mlouielu
Copy link
Copy Markdown
Contributor

Fix CI failed due to ld.gold not found.

Note: ld.gold deprecated from GNU binutils

Fix CI failed due to ld.gold not found.

Note: ld.gold deprecated from GNU binutils

* Debian moves ld.gold from binutils to binutils-gold and flag deprecated:

  https://packages.debian.org/search?suite=trixie&searchon=contents&keywords=ld.gold

* Which the GNU announced in GNU Binutils 2.44 released:

  https://lists.gnu.org/archive/html/info-gnu/2025-02/msg00001.html
@mlouielu mlouielu requested a review from LebedevRI as a code owner March 20, 2025 14:45
@LebedevRI
Copy link
Copy Markdown
Member

Thanks.
Please also add

commit f30a8f1d4c4680cf6456e91b930477a946d0884e (HEAD -> mlouielu-fix-ci)
Author: Roman Lebedev <lebedev.ri@gmail.com>
Date:   Fri Mar 21 06:41:47 2025 +0300

    Homebrew/bundle has been merged into brew

diff --git a/.github/workflows/CI-macOS.yml b/.github/workflows/CI-macOS.yml
index df265319..b7bd917f 100644
--- a/.github/workflows/CI-macOS.yml
+++ b/.github/workflows/CI-macOS.yml
@@ -48,7 +48,6 @@ jobs:
         run: |
           set -xe
           brew update --quiet
-          brew tap Homebrew/bundle
           cd "${SRC_DIR}/.ci/"
           brew bundle cleanup --quiet --force
           brew autoremove --quiet

github isn't allowing me to add it to your branch for some reason.

@mlouielu mlouielu changed the title Install binutils-gold for ld.gold Fix CI failing for Linux static analysis (unstable) & macOS homebrew Mar 21, 2025
@mlouielu
Copy link
Copy Markdown
Contributor Author

Used git am to apply the patch.

@LebedevRI LebedevRI merged commit b620c24 into darktable-org:develop Mar 21, 2025
31 of 34 checks passed
@LebedevRI
Copy link
Copy Markdown
Member

@mlouielu thank you!
This isn't worse at least.
static analysis is failing for "valid" reasons i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants