Fix build with Clang on Window#926
Merged
LebedevRI merged 2 commits intodarktable-org:developfrom Dec 14, 2025
Merged
Conversation
|
The proposed diff is not cd <path/to/repo/checkout> # NOTE: use your own path here
unzip clang-format.patch.zip
git stash # Temporairly stash away any preexisting diff
git apply clang-format.patch # Apply the diff
git add -u # Stage changed files
git commit -m "Applying clang-format" # Commit the patch
git push
git stash pop # Unstast preexisting diff
rm clang-format.patch.zip clang-format.patch |
Member
|
Please split commit in two and mention the actual error in each commit message. |
stevenlr
force-pushed
the
fix_windows_clang_build
branch
2 times, most recently
from
bdf2e5f to
04e0e01
Compare
Contributor
Author
|
Done in latest revision. |
Member
|
@stevenlr please rebase |
This created compilation issues where all SIMD intrinsics symbols were not defined in the correct namespace.
In MSVC's STL, the std::array iterators are not simply the elements pointer, and hence cannot be compared to them. Instead we dereference the iterator and take its address for comparison.
stevenlr
force-pushed
the
fix_windows_clang_build
branch
from
04e0e01 to
9fbee75
Compare
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues that made it impossible to build rawspeed on Windows with Clang (and probably MSVC too, though I have not tested that).
Note that I'm currently building the library without any of the external dependencies, and hence there could exist other problematic code paths that I'm not hitting.