Skip to content

Update code-prettify dart highlighting#1624

Merged
kwalrath merged 1 commit intodart-lang:masterfrom
parlough:fix/dart-highlighting
May 20, 2019
Merged

Update code-prettify dart highlighting#1624
kwalrath merged 1 commit intodart-lang:masterfrom
parlough:fix/dart-highlighting

Conversation

@parlough
Copy link
Copy Markdown
Member

I noticed there were a lot of old and new keywords missing or highlighted wrong on the website, so I went ahead and added everyone I found to be missing. I made this PR on the code-prettify repository as well, but it seems maintenance is quite slow over there, so I made it here as well. I'll make any requested changes in both locations and can always update again when upstream changes are made.

You can find the other PR here with some more information: googlearchive/code-prettify#592

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label May 17, 2019
@kwalrath
Copy link
Copy Markdown
Contributor

Thank you so much, @parlough! This looks great to me, but I should get a DPE to take a look, just to be sure.

@kwalrath kwalrath requested a review from johnpryan May 17, 2019 22:53
Copy link
Copy Markdown
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@ycvzyl-star
Copy link
Copy Markdown

2025-08-05T12:24:49.800Z | | | | -- defaults@1.0.4 2025-08-05T12:24:49.802Z | | | | -- clone@1.0.4
2025-08-05T12:24:49.804Z | | | +-- run-async@2.4.1
2025-08-05T12:24:49.806Z | | | +-- rxjs@7.8.2
2025-08-05T12:24:49.808Z | | | | -- tslib@2.8.1 deduped 2025-08-05T12:24:49.810Z | | | +-- string-width@4.2.3 2025-08-05T12:24:49.812Z | | | | +-- emoji-regex@8.0.0 2025-08-05T12:24:49.814Z | | | | +-- is-fullwidth-code-point@3.0.0 2025-08-05T12:24:49.816Z | | | | -- strip-ansi@6.0.1 deduped
2025-08-05T12:24:49.817Z | | | +-- strip-ansi@6.0.1
2025-08-05T12:24:49.819Z | | | | -- ansi-regex@5.0.1 2025-08-05T12:24:49.821Z | | | +-- through@2.3.8 2025-08-05T12:24:49.823Z | | | -- wrap-ansi@6.2.0
2025-08-05T12:24:49.825Z | | | +-- ansi-styles@4.3.0 deduped

@parlough parlough deleted the fix/dart-highlighting branch August 31, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants