[PLUGIN-1717]: Added implementation for openFile and openFileWithOptions#1543
Merged
Merged
Conversation
itsankit-google
left a comment
itsankit-google
left a comment
Contributor
There was a problem hiding this comment.
Also add e2e tests for this change.
Contributor
|
Bigtable e2e tests are failing currently: |
psainics
force-pushed
the
tink-issue
branch
2 times, most recently
from
June 18, 2025 07:55
87fe62c to
1331f95
Compare
Contributor
Please create a JIRA , add in a follow up PR |
sahusanket
approved these changes
Aug 8, 2025
sahusanket
left a comment
sahusanket
left a comment
Contributor
There was a problem hiding this comment.
Please squash commits before merging
| protected CompletableFuture<FSDataInputStream> openFileWithOptions(Path path, OpenFileParameters parameters) { | ||
| return CompletableFuture.supplyAsync(() -> { | ||
| try { | ||
| int bufferSize = parameters.getBufferSize() > 0 ? parameters.getBufferSize() : 4096; |
Contributor
There was a problem hiding this comment.
use DEFAULT_BUFFER_SIZE instead of 4096
| private static final String FS_SCHEME = CONF_PREFIX + "scheme"; | ||
| private static final String FS_IMPL = CONF_PREFIX + "impl"; | ||
| private static final String DECRYPTOR_IMPL = CONF_PREFIX + "decryptor.impl"; | ||
| private static final int DEFAULT_BUFFER_SIZE = 4096; |
Contributor
There was a problem hiding this comment.
how did we calculate this?
Contributor
There was a problem hiding this comment.
itsankit-google
requested changes
Aug 8, 2025
itsankit-google
left a comment
itsankit-google
left a comment
Contributor
There was a problem hiding this comment.
added one comment and one question.
itsankit-google
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix encrypted file reader for DP 2.1 and above
Bug Tracker
PLUGIN-1717
Description
Currently the file read on 2.1, 2.2 produces garbage binary data when reading an encrypted file, this is caused as new Hadoop version uses different file open methods.
This PR overrides the new file open method used and extend the decryption logic being used.
Code change
Tests
Meta
Test Case [100 - Ephemeral]
Test Case [100K - Ephemeral]
Test Case [100 - DP2.0]
Test Case [100K - DP2.0]
Test Case [100 - DP2.1]
Test Case [100K - DP2.1]
Test Case [100 - DP2.2]
Test Case [100K - DP2.2]