Draft
Conversation
Deploying datachain with
|
| Latest commit: |
98fcc8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce1bdbc6.datachain-2g6.pages.dev |
| Branch Preview URL: | https://ilongin-1636-deterministic-h.datachain-2g6.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_records()creates a temp dataset with a random UUID name. The starting checkpoint hash is derived from this name, making it different on every run — so checkpoints can never be reused forread_values,read_pandas,read_hf, and directread_recordscalls with list data.This adds deterministic content-based hashing: when
read_recordsreceives a concrete list (not a generator/iterator), a SHA256 hash is computed from the actual data and set as the starting checkpoint hash, overriding the random temp dataset name.read_valuessimilarly computes a hash from its keyword arguments. This makes checkpoint reuse work forread_values,read_pandas,read_hf, andread_recordswith list input.Generator/iterator-based inputs (e.g.
read_database,read_recordswith a generator) still produce non-deterministic hashes since the data is consumed lazily and can't be hashed without buffering it all in memory. - in order to fix this we would need change how we approach to hash calculation in DataChain as currently it can be calculated without applying steps, but in order to support generators we need to move hash calculation into applying steps itself.