Conversation
Deploying datachain with
|
| Latest commit: |
aaf9850
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a5df550.datachain-2g6.pages.dev |
| Branch Preview URL: | https://ilongin-1725-cache-fix.datachain-2g6.pages.dev |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1725 —
read_dataset(...).map(...)re-downloads files that are already in~/.datachain/cache/.Two distinct bugs, both rooted in
cache=Falsebeing treated as "ignore cache entirely" rather than "don't write to cache". Per @dmpetrov:cache=is a write switch; reads should always consult the persistent cache.Bug A — prefetcher ignores persistent. With
cache=False, prefetch>0, the prefetcher swaps to a fresh temp cache and re-downloads everything. Fix:Cachegains an optional read-onlyfallback; the temp cache uses persistent as fallback, socontains()/get_path()see hits in persistent while writes/eviction stay scoped to temp.Bug B — read path ignores persistent when
prefetch=0._caching_enabled=Falsemakesopen_object(use_cache=False)stream from remote even on a cache hit. Fix: decoupled_caching_enabled— it now gates writes (ensure_cached) only; reads (open_object,get_local_path) always consult cache.Applied to all 5 read sites.