Address CodeRabbit accessibility feedback from PR #593#595
Merged
jrhoads merged 1 commit intoaccessibilityfrom Apr 3, 2026
Merged
Address CodeRabbit accessibility feedback from PR #593#595jrhoads merged 1 commit intoaccessibilityfrom
jrhoads merged 1 commit intoaccessibilityfrom
Conversation
- Use semantic button for facet search clear control (SearchBox) - Fix Header search() to use passed query and drop empty query param - Add aria-pressed to filter toggle button - Align DataCiteButton secondary color with CSS variable - Add :focus-visible parity for .button and facet clear focus ring Co-authored-by: Joseph Rhoads <jrhoads@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #593, implementing the actionable CodeRabbit review items.
Changes
#search-clear-facets) with a nativebutton(type="button") so it is focusable and keyboard-operable; kept the same id for styling; clarifiedtitle/aria-labelto "Clear search input"; adjusted global CSS for button layout and:focus-visibleoutline.search(query)to use the passed-inquerywhen setting or removing thequeryURL parameter, so clearing the field removesqueryfrom the URL instead of leaving?query=.aria-pressed={isActive}on the filter toggle for correct toggle semantics.var(--datacite-color-primary, #243b54)so it tracks the global CSS variable..button:hoverwith.button:focus-visiblefor equivalent keyboard focus styling.Testing
yarn type-checkcurrently fails on pre-existing test file issues unrelated to this change.Base branch
Targets
accessibilityso these fixes can merge into the same line of work as PR #593.