Skip to content

Fabrica build issues. #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svogt0511 merged 13 commits into from
Apr 20, 2026
Merged

Fabrica build issues. #962

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
58959d7
Try amondnet/vercel-action upgrade.
svogt0511 Apr 17, 2026
c1aa93c
Try amondnet/vercel-action upgrade.
svogt0511 Apr 17, 2026
d0888c4
Try amondnet/vercel-action upgrade.
svogt0511 Apr 17, 2026
612d0bf
Try amondnet/vercel-action upgrade.
svogt0511 Apr 17, 2026
9e6b1d1
Try amondnet/vercel-action upgrade.
svogt0511 Apr 17, 2026
3656955
Upgrade github actions to node v24
svogt0511 Apr 17, 2026
017ca41
Update Fabrica to use node v24
svogt0511 Apr 17, 2026
9b6234a
Update Fabrica to use node v24
svogt0511 Apr 17, 2026
a76f141
Update Fabrica to use node v24
svogt0511 Apr 17, 2026
d140ea0
Update Fabrica to use node v24
svogt0511 Apr 17, 2026
061ed14
Update Fabrica to use node v24
svogt0511 Apr 17, 2026
38e7849
Update Fabrica to use node v24 - implement suggestions from coderabbitai
svogt0511 Apr 20, 2026
cbdedb9
Remove coderabbit suggested change.
svogt0511 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/branch_to_staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Extract variables
shell: bash
Expand All @@ -39,7 +39,7 @@ jobs:
id: extract_variables

- name: Vercel deploy staging
uses: amondnet/vercel-action@v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ jobs:
steps:
- name: Branch name
run: echo running on branch ${GITHUB_REF##*/}
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '22'
node-version: '24'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
- uses: actions/cache@v5
id: cypress-cache
with:
path: |
Expand All @@ -38,7 +38,7 @@ jobs:
./node_modules/.bin/ember build --output-path="test_build" --environment=development

- name: Upload Test Build artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: test_build
path: test_build/
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
name: Generate changelog
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v6

- name: Generate changelog
uses: charmixer/auto-changelog-action@v1.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/cypress_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ jobs:
# matrix:
# containers: [1, 2, 3, 4, 5]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '22'
node-version: '24'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
- uses: actions/cache@v5
id: cypress-cache
with:
path: |
Expand All @@ -28,7 +28,7 @@ jobs:
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}

- name: Download Test Build artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: test_build
path: test_build/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Extract variables
shell: bash
Expand All @@ -41,7 +41,7 @@ jobs:
id: extract_variables

- name: Vercel deploy
uses: amondnet/vercel-action@v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ember_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ jobs:
strategy:
fail-fast: true
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '22'
node-version: '24'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
- uses: actions/cache@v5
id: cypress-cache
with:
path: |
Expand All @@ -26,7 +26,7 @@ jobs:
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}

- name: Download Test Build artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: test_build
path: test_build/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/preview-app-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Vercel deploy
uses: amondnet/vercel-action@v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ jobs:
environment: vercel-bracco-preview
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Vercel deploy preview
uses: amondnet/vercel-action@225d234cfe5340ca1f9a6cd158338126b5b6845f # v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Extract variables
shell: bash
Expand All @@ -40,7 +40,7 @@ jobs:
id: extract_variables

- name: Vercel deploy production
uses: amondnet/vercel-action@v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand All @@ -57,7 +57,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Extract variables
shell: bash
Expand All @@ -68,7 +68,7 @@ jobs:
id: extract_variables

- name: Vercel deploy test
uses: amondnet/vercel-action@v25.1.1
uses: amondnet/vercel-action@v42.2.0
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
Expand Down
3 changes: 2 additions & 1 deletion ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ module.exports = function (defaults) {
},
},
minifyCSS: {
options: { processImport: true }
options: { processImport: true },
enabled: false
},
'ember-cli-babel': {
includePolyfill: true
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
"xml2js": "^0.5.0"
},
"engines": {
"node": "^22.11.0"
"node": "^24.0.0"
},
"ember": {
"edition": "octane"
Expand Down
Loading