Skip to content

Remove totals and total pages from enrichments output#1515

Merged
wendelfabianchinsamy merged 1 commit intomasterfrom
remove-totals-from-enrichment-response
Apr 16, 2026
Merged

Remove totals and total pages from enrichments output#1515
wendelfabianchinsamy merged 1 commit intomasterfrom
remove-totals-from-enrichment-response

Conversation

@wendelfabianchinsamy
Copy link
Copy Markdown
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.


def build_meta(enrichments, cursor_page)
enrichments_total = enrichments.count
# enrichments_total = enrichments.count
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to delete these?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be adding it back in time

@wendelfabianchinsamy wendelfabianchinsamy merged commit 4c643ac into master Apr 16, 2026
19 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the remove-totals-from-enrichment-response branch April 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants