Skip to content

Json schema tweaks#1516

Open
codycooperross wants to merge 6 commits intopb325-json-metadata-validationfrom
json-schema-tweaks
Open

Json schema tweaks#1516
codycooperross wants to merge 6 commits intopb325-json-metadata-validationfrom
json-schema-tweaks

Conversation

@codycooperross
Copy link
Copy Markdown
Contributor

Purpose

  • Removes validation for identifier, which isn't present in the database schema.
  • Validates identifiers instead of alternate_identifiers to align with database column naming and internal identifiers attribute naming.
  • Validates types instead of raw_types and allows additional properties (like bibtex and schemaOrg) in the JSON Schema.
  • Removes requirement for types.resourceType, which is an optional field.
  • Removes update_field_of_science, which seemed to cull some subject properties; for example, when subjects.subject is submitted as an integer.
  • Allows empty string affiliation.name since this is permitted by the XSD.
  • Allows nil for identifiers.identifier and identifiers.identifierType since nils can be appear for these properties when reading XML.
  • Does not require titles.title or subjects.subject since these can be blank if the elements are submitted empty via XML.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant