Json schema tweaks#1516
Open
codycooperross wants to merge 6 commits intopb325-json-metadata-validationfrom
Open
Json schema tweaks#1516codycooperross wants to merge 6 commits intopb325-json-metadata-validationfrom
codycooperross wants to merge 6 commits intopb325-json-metadata-validationfrom
Conversation
…nd with complete data
…pe; identifier and identifierType can be null in some cases
…hemaOrg, and others; resourceType is not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
identifier, which isn't present in the database schema.identifiersinstead ofalternate_identifiersto align with database column naming and internalidentifiersattribute naming.typesinstead ofraw_typesand allows additional properties (likebibtexandschemaOrg) in the JSON Schema.types.resourceType, which is an optional field.update_field_of_science, which seemed to cull some subject properties; for example, whensubjects.subjectis submitted as an integer.affiliation.namesince this is permitted by the XSD.identifiers.identifierandidentifiers.identifierTypesince nils can be appear for these properties when reading XML.titles.titleorsubjects.subjectsince these can be blank if the elements are submitted empty via XML.closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: