fix: Improve set institution handling for DataKinders#257
Open
fix: Improve set institution handling for DataKinders#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Tasks
EDVISEWEBAPP-4: Replace "DKer must set institution" error message with info level
EDVISEWEBAPP-5: Fix disappearing "successfully set institution" message on Set Institution page
Summary
Adds a variant-based
Alertcomponent, migrates formerErrorAlertusage, improves Set Institution loading/success UX, and consolidates Datakinder “set institution” copy onSetInstonly (removes PHP constant, query param, and shared Inertia prop).Changes
resources/js/Components/Alert.jsx— NewAlertwithvariant:danger|warning|info|success(same props as before:mainMsg,msgDict,excludeValue,className).ErrorAlert.jsx—FileUpload,RunInference,Dashboarduse<Alert variant="danger" />.SetInst.jsx— State-driven submit feedback (noinnerHTML); successAlert;router.reload({ only: ['inst_id'] })after set; warning text hardcoded on this page.InstitutionHelper— RemoveSET_INST_REQUIRED_MESSAGE; Datakinder without session institution returns['', '']fromGetInstitution.RequireInstitution— Redirect toset-instwithoutmessage; JSON returnsInstitution required.HandleInertiaRequests— Dropset_inst_required_messageshared prop.routes/web.php—SetInstrender withoutmessageprop.