feat: remove custom institution type; align create/edit with API school-type rules#258
Open
feat: remove custom institution type; align create/edit with API school-type rules#258
Conversation
- Require exactly one of PDP, Edvise, or Legacy on create - Drop allowed_schemas/UNKNOWN from payloads; label fieldset Institution type Made-with: Cursor
- CreateInst: send pdp_id only when PDP is selected; fix allowed_emails empty check - EditInst: require exactly one of PDP, Edvise, or Legacy before submit Made-with: Cursor
Keep only custom-removal edits on the edit page (no Custom option, no UNKNOWN allowed_schemas, Institution type label). Drop the exactly-one-type client check added for API parity; edit flow is out of scope for this PR. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
pdp_idonly when PDP); schema / allowed-email handling consistent with the hardened API (Avoid client-driven allowed_schemas that mixed custom behavior with UNKNOWN; school type + API schema groups are the source of truthcontext
The backend is dropping custom institutions; the admin UI must not offer Custom and must send payloads the API accepts. This pairs with the edvise-api PR - datakind/edvise-api#228
https://app.asana.com/1/6325821815997/project/1208486153653829/task/1213791624909790?focus=true
testing
Tested deployed feature branch on dev with its associated edvise-api feature branch: confirmed that custom is removed and that school creation is working as intended.
questions