AlterType, fix payload serialization#105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the resulting serialization for AlterTypePayload as follows: the
operationlayer is removed (the Data API does not expect it).So instead of having e.g.
we now end up with the working json:
To achieve this, some of the logic around marshaling of the AlterTypePayload are applied (including the introduction of a "key name" string method to the alter type operation interface for building the appropriate payload).
(Besides the altered unit test, this branch is tested manually by altering a type in both
addandrenameways, successfully).Reference Slack conversation: here.