Skip to content

HCD-241: Add a dedicated DSE 6.9 upgrade test#90

Open
szymon-miezal wants to merge 9 commits into
mainfrom
HCD-241
Open

HCD-241: Add a dedicated DSE 6.9 upgrade test#90
szymon-miezal wants to merge 9 commits into
mainfrom
HCD-241

Conversation

@szymon-miezal

@szymon-miezal szymon-miezal commented Feb 13, 2026

Copy link
Copy Markdown

The goal of this patch is to add a distinct upgrade test for DSE 6.9 upgrade path.
The test aims at preparing some lightweight data and conduct a rolling upgrade
while inserting more data - the goal is to ensure the internode communication does not
break when cluster is in a mixed version state.
The test consists from encrypted and non-encrypted variant.

Complementary ccm PR: datastax/cassandra-ccm#3

It is a test for datastax/cassandra#2240

How to run the test locally:

pytest -s --execute-upgrade-tests --cassandra-dir=<path_to_CC_repo> upgrade_tests/upgrade_from_dse_test.py::TestUpgradeFromDSEWithConcurrentWritesAndRestarts::test_upgrade_from_6_9

Comment thread dtest.py


@flaky(rerun_filter=test_failure_due_to_timeout)
#@flaky(rerun_filter=test_failure_due_to_timeout)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove

Comment thread requirements.txt
# In case you want to test a patch with your own CCM branch, further to changing below CCM repo and branch name, you need to add -e flag at the beginning
# Example: -e git+https://github.com/userb/ccm.git@cassandra-17182#egg=ccm
git+https://github.com/datastax/cassandra-ccm.git@converged-cassandra#egg=ccm
-e git+https://github.com/datastax/cassandra-ccm.git@HCD-267#egg=ccm

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove once datastax/cassandra-ccm#3 is merged

@szymon-miezal szymon-miezal changed the title HCD-241: Add an upgrade test which exercises DSE 6.9 -> CC upgrade path exclusively HCD-241: Add a dedicated DSE 6.9 upgrade test Feb 20, 2026
@szymon-miezal szymon-miezal marked this pull request as ready for review February 20, 2026 11:03
@szymon-miezal

Copy link
Copy Markdown
Author

Note that 25fa91b is purely experimental, will be dropped before merging.

upgraded_node_3 = self._upgrade_node(cluster, nodes[2], internode_encryption=internode_encryption)
self._assert_insert_select_works(upgraded_node_3, 300, 400)

# rolling restart post upgrade

@bereng bereng Feb 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be explained imo as to why are we doing it. Couldn't all these be just a loop against an array `upgraded_nodes' i.e.?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, I thought about not polluting the loop with weird usage of index to get different ranges of data to write but I can try it out.

I do agree a comment explaining the motivation for post upgrade restart is a good idea.

Comment thread upgrade_tests/upgrade_from_dse_test.py
szymon-miezal and others added 6 commits April 1, 2026 08:36
The goal of this patch is to add a distinct upgrade test for DSE 6.9 upgrade path.
The test aims at preparing some lightweight data and conduct a rolling upgrade
while inserting more data - the goal is to ensure the internode communication does not
break when cluster is in a mixed version state.
The test consists from encrypted and non-encrypted variant.
Jenkins does not have permissions to checkout from bdp
Comment thread dtest_setup.py
r'Received a read request from .* for a token .* that is not owned by the current replica .* key=cassandra .*'
r'Received a read request from .* for a token .* that is not owned by the current replica .* key=cassandra .*',
# the two below error patterns are needed by DSE upgrade tests
r'that is incompatible with the version this node can handle',

@michaelsembwever michaelsembwever Apr 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, this line addresses (by suppression) HCD-193
https://github.com/riptano/bdp/pull/21617

@szymon-miezal

Copy link
Copy Markdown
Author

It seems there has been some activity on this PR while I was away, I will let myself review what has changed and what the next steps should be.

@bereng

bereng commented Apr 23, 2026

Copy link
Copy Markdown

@szymon-miezal https://datastax.jira.com/browse/HCD-241?focusedCommentId=801910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants