Fix missing optional dependency for matching example (annoy)#204
Open
Mountain-Biker wants to merge 1 commit intodatawhalechina:mainfrom
Open
Fix missing optional dependency for matching example (annoy)#204Mountain-Biker wants to merge 1 commit intodatawhalechina:mainfrom
Mountain-Biker wants to merge 1 commit intodatawhalechina:mainfrom
Conversation
Collaborator
|
Hi,很高兴你能选择来PR 不过这么做有个问题,在annoy安装时,需要C++环境才可以被编译,会影响使用pip直接安装该库。所以关于Annoy的安装放在文档里有介绍link。另外我们同时支持三种向量数据库的插入操作,Anooy这么做后,其他两个也需要设置这些,为了一个库做一个单独的分组这很奇怪。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request / 拉取请求
What does this PR do? / 这个PR做了什么?
当我在运行README 文档中“快速开始”中的示例时,我发现了一个bug

我发现原因在于pyproject.toml 中,annoy 在optional dependencies list 中,所以
uv sync并不会安装annoy。为了解决这个问题,需要手动安装
uv pip install ".[annoy]"由于我们通过uv配置环境,所以在运行程序时应该用
uv run运行代码。Type of Change / 变更类型
Related Issues / 相关Issues
Fixes #(issue number) / 修复 #(issue编号)
How to Test / 如何测试
Checklist / 检查清单
python config/format_code.py) / 代码遵循项目风格(运行了格式化脚本)Additional Notes / 附加说明
Any other information for reviewers / 给审查者的其他信息