Add orca-replay skill (category: development-code) - #326
Merged
Merged
Conversation
Owner
|
Thanks for the follow-up — category is now a valid skill enum value ( Reviewed for security, prompt injection, and fit with this collection. Security / prompt injection: No classic malice in the skill text. Requiring the agent to answer from the trace (and to keep Schema/ Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #322, as invited: "Happy to re-review a follow-up with
category: development-code."Disclosure: I maintain OrcaReplay. Apache-2.0, free, no paid tier, no account.
The one change
developmentis not in the enum. I checkedscripts/skill-schema.jsonrather than taking the value on trust —/properties/categorylists 27 values, anddevelopment-codeis the one you named. The file is otherwise byte-identical to what you reviewed in #322.Everything else, left as reviewed
## Requirements, line 89), since you said an external install is fine as long as it stays there.Why a fresh PR rather than a reopen
You offered either. A fresh one seemed cleaner than reopening a branch whose head now differs from what you reviewed; this way the diff you see is the file as it will land. Say the word if you would rather have had #322 reopened and I will close this.
Nothing else to flag — the blocking item was one line and this is it.