Skip to content

Recalculate parent sections when necessary #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-cnz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Recalculate parent sections when necessary #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d8a94
Recalculate parent sections when necessary
james-cnz May 22, 2023
91f594c
Fetch parent section information for correct user
james-cnz Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,11 @@ class format_onetopic extends core_courseformat\base {
/** @var array Messages to display */
public static $formatmsgs = [];

/** @var stdClass Onetopic-specific extra section information */
private $parentsections = null;
/** @var array Onetopic-specific extra section information */
private $parentsections = [];

/** @var course_modinfo|null Mod info used to calculate parent sections */
private $parentsectionsmodinfo = null;

/** @var array Modules used in template */
public $tplcmsused = [];
Expand Down Expand Up @@ -1178,14 +1181,16 @@ public function get_config_for_external() {
*/
public function fot_get_sections_extra() {

if (isset($this->parentsections)) {
$modinfo = $this->courseid ? $this->get_modinfo() : null;

if ($this->parentsectionsmodinfo == $modinfo) {
return $this->parentsections;
}

$course = $this->get_course();
$realcoursedisplay = property_exists($course, 'realcoursedisplay') ? $course->realcoursedisplay : false;
$firstsection = ($realcoursedisplay == COURSE_DISPLAY_MULTIPAGE) ? 1 : 0;
$sections = $this->get_sections();
$sections = $modinfo->get_section_info_all();
$parentsections = [];
$level0section = null;
foreach ($sections as $section) {
Expand All @@ -1195,9 +1200,10 @@ public function fot_get_sections_extra() {
} else {
$parent = $level0section;
}
$parentsections[$section->section] = $parent;
$parentsections[$section->id] = $parent ? $parent->id : null;
}
$this->parentsections = $parentsections;
$this->parentsectionsmodinfo = $modinfo;
return $parentsections;
}

Expand All @@ -1222,8 +1228,9 @@ public function section_get_available_hook(section_info $section, &$available, &

// The tab visibility depend of parent visibility.
$parentsections = $this->fot_get_sections_extra();
$parent = $parentsections[$section->section];
if ($parent) {
$parentid = $parentsections[$section->id];
if ($parentid) {
$parent = $section->modinfo->get_section_info_by_id($parentid);
if (!($parent->visible && $parent->available)) {
$available = false;
if (!$parent->uservisible) {
Expand Down
Loading