[Feat]: Add 'snap on settle' behavior option for dragFree#1297
Open
ehellman wants to merge 2 commits intodavidjerleke:masterfrom
Open
[Feat]: Add 'snap on settle' behavior option for dragFree#1297ehellman wants to merge 2 commits intodavidjerleke:masterfrom
ehellman wants to merge 2 commits intodavidjerleke:masterfrom
Conversation
Owner
|
Hi @ehellman, Welcome, and glad to have you here ⭐! Unfortunately, I didn’t get a chance to give you a heads-up that the generator has been deprecated and the documentation structure has changed quite a bit: Before I can test this PR, a couple of updates are needed:
Sorry about the inconvenience, and thanks again for taking the time to work on this. Looking forward to testing the feature once it’s updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
'snap'mode for thedragFreeoption, allowing a "hybrid"-mode of default snapping and free-dragging. It acts just likedragFree: true, but the final settle destination is always at a snapping point.The documentation for
dragFreehas been updated accordingly, as well as the documentation forskipSnapswhich previously mentioneddragFree: truebut now also includesdragFree: 'snap'.Since the values for
dragFreehas been changed from justtrue/false, I refactored the documentation components a bit to radio buttons as well as adding a title.Video
slidesToScroll: 1screenrecord.mp4
slidesToScroll: 2screenrecord.mp4