Skip to content

Fix typos & handle undefined max_reps#24

Open
mkatychev wants to merge 3 commits into
davidson16807:masterfrom
mkatychev:chore/typos
Open

Fix typos & handle undefined max_reps#24
mkatychev wants to merge 3 commits into
davidson16807:masterfrom
mkatychev:chore/typos

Conversation

@mkatychev

@mkatychev mkatychev commented Aug 5, 2024

Copy link
Copy Markdown
  • used typos-cli to fix typos in codebase
  • fixed warning when max_reps is undefined in _match_repetition

Comment thread relativity.scad
Comment on lines +423 to +433
function opt_decr(opt_num) =
is_undef(opt_num) ? undef
: opt_num - 1 ;

function _match_repetition(string, regex, min_reps, max_reps, pos, ignore_case=false) =
pos == undef?
undef
: pos > len(string)?
undef
: _null_coalesce(
_match_repetition(string, regex, min_reps-1, max_reps-1,
_match_parsed_rx(string, regex, pos, ignore_case=ignore_case),
_match_repetition(string, regex, opt_decr(min_reps), opt_decr(max_reps),

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the code change that was done to handle #21

@mkatychev mkatychev changed the title Fix typos & add config Fix typos & handle undefined max_reps Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant