Hostname label separator fixes#221
Closed
davishmcclurg wants to merge 4 commits into
Closed
Conversation
davishmcclurg
commented
Jun 15, 2025
davishmcclurg
commented
Owner
- Support all IDNA separators (., 。, ．, ｡)
- Disallow trailing separators
`String#split` drops trailing null fields by default, which means the dots weren't getted added back by `join` for validation against `HOSTNAME_REGEX`. Passing `-1` to `split` returns empty strings instead. Ruby [docs][0]: > If limit is negative, it behaves the same as if limit was zero, meaning that there is no limit, and trailing empty substrings are included. [0]: https://ruby-doc.org/3.4.1/String.html#method-i-split
[RFC 3490][0] says: > Whenever dots are used as label separators, the following > characters MUST be recognized as dots: U+002E (full stop), U+3002 > (ideographic full stop), U+FF0E (fullwidth full stop), U+FF62 > (halfwidth ideographic full stop) [0]: https://datatracker.ietf.org/doc/html/rfc3490#section-3.1
Using `bin/hostname_character_classes`.
Owner
Author
|
Here instead: #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.