feat(dashboard): wallet layout split tabs#5025
Draft
rpavlini wants to merge 2 commits into
Draft
Conversation
Signed-off-by: rpavlini <rpavlinic@daytona.io>
|
View your CI Pipeline Execution ↗ for commit 269a18e
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 18 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Collaborator
Author
|
@cubic-dev-ai review this PR |
@rpavlini I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
2 issues found across 18 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/dashboard/src/components/billing/AutomaticTopUpCard.tsx">
<violation number="1" location="apps/dashboard/src/components/billing/AutomaticTopUpCard.tsx:27">
P1: Automatic top-up state starts as `undefined`, causing a false dirty state on first render and allowing an unintended Save request before form state is synchronized from the wallet.</violation>
</file>
<file name="apps/dashboard/src/App.tsx">
<violation number="1" location="apps/dashboard/src/App.tsx:370">
P2: The wallet index route mounts `Wallet` and then redirects, causing avoidable billing query work before navigation to `/general`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| } | ||
|
|
||
| export function AutomaticTopUpCard({ organizationId, wallet }: AutomaticTopUpCardProps) { | ||
| const [automaticTopUp, setAutomaticTopUp] = useState<AutomaticTopUp | undefined>(undefined) |
There was a problem hiding this comment.
P1: Automatic top-up state starts as undefined, causing a false dirty state on first render and allowing an unintended Save request before form state is synchronized from the wallet.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/dashboard/src/components/billing/AutomaticTopUpCard.tsx, line 27:
<comment>Automatic top-up state starts as `undefined`, causing a false dirty state on first render and allowing an unintended Save request before form state is synchronized from the wallet.</comment>
<file context>
@@ -0,0 +1,195 @@
+}
+
+export function AutomaticTopUpCard({ organizationId, wallet }: AutomaticTopUpCardProps) {
+ const [automaticTopUp, setAutomaticTopUp] = useState<AutomaticTopUp | undefined>(undefined)
+ const paymentMethodsQuery = usePaymentMethodsQuery({ organizationId })
+ const setAutomaticTopUpMutation = useSetAutomaticTopUpMutation()
</file context>
| element: <BillingOwnerAccessOutlet pageTitle="Wallet" />, | ||
| children: [{ index: true, lazy: lazyRoutes.Wallet }], | ||
| children: [ | ||
| { index: true, lazy: lazyRoutes.Wallet }, |
There was a problem hiding this comment.
P2: The wallet index route mounts Wallet and then redirects, causing avoidable billing query work before navigation to /general.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/dashboard/src/App.tsx, line 370:
<comment>The wallet index route mounts `Wallet` and then redirects, causing avoidable billing query work before navigation to `/general`.</comment>
<file context>
@@ -366,7 +366,10 @@ const router = createBrowserRouter([
element: <BillingOwnerAccessOutlet pageTitle="Wallet" />,
- children: [{ index: true, lazy: lazyRoutes.Wallet }],
+ children: [
+ { index: true, lazy: lazyRoutes.Wallet },
+ { path: ':page', lazy: lazyRoutes.Wallet },
+ ],
</file context>
Suggested change
| { index: true, lazy: lazyRoutes.Wallet }, | |
| { index: true, loader: () => redirect(`${RoutePath.BILLING_WALLET}/general`) }, |
vedranjukic
force-pushed
the
main
branch
2 times, most recently
from
2c15a7f to
b40f732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Split the Wallet page into General and History tabs with URL-based navigation to improve clarity. Added overview, automatic top-up, and one-time top-up cards for faster billing actions.
New Features
Refactors
WalletOverviewCard,AutomaticTopUpCard, andOneTimeTopUpCard.components/billing/*and fixed relative imports.Wallet.tsxwith smaller components, improved loading skeletons, and a clearer error state.Written for commit 269a18e. Summary will update on new commits.