Skip to content

Tabs feedback#5747

Open
michaelmkraus wants to merge 403 commits intomainfrom
feat-1453-tabs-feedback
Open

Tabs feedback#5747
michaelmkraus wants to merge 403 commits intomainfrom
feat-1453-tabs-feedback

Conversation

@michaelmkraus
Copy link
Copy Markdown
Contributor

@michaelmkraus michaelmkraus commented Jan 8, 2026

Proposed changes

  • Refactored to Buttons: Changed tab-item structure from radio inputs to native elements to improve semantics and accessibility.
  • Added Truncation Tooltip: Implemented logic to automatically detect truncated text and display a DBTooltip for overflowing content.
  • Corrected Alignment: Fixed vertical tab layout, trailing icon positioning, and enforced tooltip placement.
  • Updated Framework Config: Adjusted Angular controlValueAccessor to support the new button-based state (internalActive) instead of checked inputs.

resolves https://github.com/db-ux-design-system/core-team/issues/1634
closes #4898
resolves #5046
resolves #2477
resolved #3331

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/feat-1453-tabs-feedback

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: bf9216f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nmerget nmerget self-requested a review January 26, 2026 07:37
@nmerget nmerget moved this from 🏗 In progress to 👀 Actively In Review in UX Engineering Team Backlog Jan 26, 2026
* The disabled attribute can be set to keep a user from clicking on the tab-item.
*/
disabled?: boolean | string;
isDisabled?: boolean;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you rename this and removed the | string?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rename it because using standard HTML attribute names triggered unexpected behavior in Stencil and Angular due to automatic attribute reflection on the host element.
I will try to find another solution.

github-actions bot and others added 2 commits March 16, 2026 11:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus michaelmkraus marked this pull request as ready for review March 16, 2026 14:42
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏘components 📺showcases Changes to 1-n showcases

Projects

Status: No status
Status: 🏗 In progress

4 participants