Draft
Conversation
micha91
requested changes
Dec 9, 2024
Comment on lines
+121
to
+124
| input_str = ";".join( | ||
| remove_width_and_height(eit).model_dump_json() | ||
| for eit in elk_input | ||
| ) |
Collaborator
There was a problem hiding this comment.
This should not be necessary and does not really look clean to me. You could argue that mocking the elk_input instead is fine as it should be tested in context_diagrams, but I would prefer to work with real input here to ensure that we know, if an update of context diagrams changes the rendering of diagrams
Collaborator
Author
There was a problem hiding this comment.
The width and height calculations depend from the used platform (MacOS, Linux or Windows). They are not important for identifying if the context-diagram changed, the collected input elements are reliable and give developers the freedom of choice for their used platform without broken tests.
This removes unncessary iteration over all `work_items`.
87b1dbf to
d9191c9
Compare
add_custom_diagrams serializer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new
add_custom_diagramsserializer. This serializer is configured like that:and therefore multiple custom diagrams can be added as custom fields to a work item. Also there is control about the
capella_attrandpolarion_idnow.