feat(resource_redshift_database): basic zeroetl support#43
Open
Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Open
feat(resource_redshift_database): basic zeroetl support#43Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Conversation
|
Thank you for your contribution. Again, sorry for the late feedback. The PR looks good so far but an integration/acceptance test is missing. Please provide one simple parameterized test that can be used to test a zeroetl database integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmallPR which enables zeroetl support for the database resource
Unfortunately, I haven't found a way to query on the cluster if a db is associated with an integration
Ref: https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_DATABASE.html