Skip to content

Fix Self import for Python 3.10 compatibility#12809

Merged
tauhid621 merged 2 commits intomainfrom
tauhid621/fix_typing_self_import
Apr 9, 2026
Merged

Fix Self import for Python 3.10 compatibility#12809
tauhid621 merged 2 commits intomainfrom
tauhid621/fix_typing_self_import

Conversation

@tauhid621
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verify import succeeds on Python 3.10
  • Verify import succeeds on Python 3.11+
  • Run existing test suite

🤖 Generated with Claude Code

@tauhid621 tauhid621 requested a review from a team as a code owner April 9, 2026 13:13
@cla-bot cla-bot bot added the cla:yes label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tauhid621 tauhid621 force-pushed the tauhid621/fix_typing_self_import branch from a540496 to 53c5baf Compare April 9, 2026 13:15
@tauhid621 tauhid621 added the Skip Changelog Skips GHA to check for changelog file label Apr 9, 2026
aahel
aahel previously approved these changes Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.40%. Comparing base (1c98ad2) to head (e18d0e4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12809      +/-   ##
==========================================
- Coverage   91.41%   91.40%   -0.02%     
==========================================
  Files         203      203              
  Lines       25875    25879       +4     
==========================================
+ Hits        23654    23655       +1     
- Misses       2221     2224       +3     
Flag Coverage Δ
integration 88.26% <75.00%> (-0.02%) ⬇️
unit 65.52% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.52% <75.00%> (+<0.01%) ⬆️
Integration Tests 88.26% <75.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tauhid621 tauhid621 merged commit 2384e7c into main Apr 9, 2026
122 of 124 checks passed
@tauhid621 tauhid621 deleted the tauhid621/fix_typing_self_import branch April 9, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes Skip Changelog Skips GHA to check for changelog file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants