handle AdminAPI client host and url differently#297
Merged
Conversation
reneruck-dbt
enabled auto-merge (squash)
August 22, 2025 14:29
reneruck-dbt
changed the title
reneruck-dbt
changed the title
reneruck-dbt
force-pushed
the
admin_agent_host_protocol
branch
from
August 22, 2025 15:35
9a3d312 to
5e2a7ee
Compare
DevonFulcher
approved these changes
Aug 22, 2025
DevonFulcher
left a comment
DevonFulcher
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Please test it out manually before merging while we don't have automated integration tests yet. There is some guidance here. Personally, I typically use task client to test.
…ong a finished url instead of the host
reneruck-dbt
force-pushed
the
admin_agent_host_protocol
branch
from
August 22, 2025 15:49
5e2a7ee to
ca4db24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assemble the URL for the admin API client at config load time and pass along a finished url instead of the host