Return dimension values query errors as tool results#796
Merged
Conversation
wiggzz
force-pushed
the
wtj/DI-4274-dbt-mcp-dimension-values-error-result
branch
from
eb34152 to
ad04cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
get_dimension_valuescan fail because the model supplied an invalid dimension or metric. Those query-level failures should be returned to the model for self-correction instead of being raised as generic runtime errors.What
This adds a typed dimension-values error result from the Semantic Layer fetcher and has the public single-project and multi-project tools return either the success response or typed error response. Operational Semantic Layer failures still propagate as real exceptions.
Notes
Drafted by GPT-5 Codex under the direction of @wiggzz.