Fix changelog check to skip auto-generated release PRs#839
Closed
alan-andrade wants to merge 1 commit into
Closed
Conversation
🤖 Generated with Claudio Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alan-andrade
requested review from
a team,
b-per,
jairus-m and
jasnonaz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto-generated release PRs (branch
release/*) runchangie merge, which rewritesCHANGELOG.md. Thecheck-changelogjob then fails them on its "don't edit CHANGELOG.md manually" rule. The job already had a guard meant to exempt release PRs, but it testedgithub.event.head_commit.message, which is only populated onpushevents and is empty onpull_requestevents, so the guard never took effect and every release PR failed the check.What
Gate the job on
github.head_refinstead, so it skipsrelease/*branches. Feature PRs are unaffected and still require a changie entry and still may not hand-editCHANGELOG.md.Drafted by Claude Opus 4.8 under the direction of @alan-andrade