Fix transient progress erase clobbering header line.#205
Merged
Conversation
Clear the blank line under the table first, then move up per row without scrolling past the topmost table line. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the terminal “transient progress” cleanup in benchmark.sh so clearing the progress table doesn’t clobber the header line above it, matching the script’s transient output behavior when --compare is used on a TTY.
Changes:
- Clear the trailing blank line under the progress table first, then clear each printed progress line while moving the cursor upward.
- Avoid moving the cursor above the topmost table line during cleanup.
Use $progress_lines in the numeric test so -le compares the variable value. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the blank line under the table first, then move up per row without scrolling past the topmost table line.