Skip to content

Fix/no explicit dispose #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickKhalow merged 5 commits into from
May 15, 2026
Merged

Fix/no explicit dispose #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10c1544
silent drop fix
NickKhalow May 14, 2026
e5b8af1
Merge remote-tracking branch 'origin/main' into fix/no_explicit_dispose
NickKhalow May 14, 2026
06e0a3a
Revert "silent drop fix"
NickKhalow May 14, 2026
0254da1
make callback background threads
NickKhalow May 14, 2026
5fa32c2
comment
NickKhalow May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Runtime/Scripts/Internal/FFIClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private static void InitializeSdk()
{
}

Utils.Debug("FFIServer - Initialized");
Utils.Debug($"FFIServer - Initialized, capture logs: {captureLogs}");
initialized = true;
}

Expand Down Expand Up @@ -198,7 +198,7 @@ out UIntPtr dataLen
NativeMethods.FfiDropHandle(handle);

#if LK_VERBOSE
Debug.Log($"FFIClient response of type: {response.MessageCase} with asyncId: {AsyncId(response)}");
Utils.Debug($"FFIClient response of type: {response.MessageCase} with asyncId: {AsyncId(response)}");
#endif

return response;
Expand All @@ -221,6 +221,12 @@ private static unsafe void FFICallback(IntPtr data, UIntPtr size)
return;
#endif

// Prevents app freeze on exit due the registered threads via IL2CPP context
// We already had this issue before and the full explanation is here:
// https://support.unity.com/hc/en-us/requests/3055850
System.Threading.Thread current = System.Threading.Thread.CurrentThread;
if (current.IsBackground == false) current.IsBackground = true;

try
{
if (isDisposed) return;
Expand All @@ -235,7 +241,7 @@ private static unsafe void FFICallback(IntPtr data, UIntPtr size)
{
case FfiEvent.MessageOneofCase.Logs:

Debug.Log($"LK_DEBUG: {response.Logs.Records}");
Utils.Debug($"LK_DEBUG: {response.Logs.Records}");
break;
case FfiEvent.MessageOneofCase.PublishData:
break;
Expand Down
4 changes: 2 additions & 2 deletions Runtime/Scripts/Internal/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ internal static class Utils
[Conditional(LK_DEBUG)]
public static void Debug(object msg)
{
UnityEngine.Debug.unityLogger.Log(LogType.Log, $"{PREFIX}: {msg}");
UnityEngine.Debug.unityLogger.Log(LogType.Log, $"{PREFIX}: {DateTime.UtcNow:HH:mm:ss.fff} : {msg}");
}

public static void Error(object msg)
{
UnityEngine.Debug.unityLogger.Log(LogType.Error, $"{PREFIX}: {msg}");
UnityEngine.Debug.unityLogger.Log(LogType.Error, $"{PREFIX}: {DateTime.UtcNow:HH:mm:ss.fff} : {msg}");
}

public static GraphicsFormat GetSupportedGraphicsFormat(GraphicsDeviceType type)
Expand Down