-
Notifications
You must be signed in to change notification settings - Fork 12
Learn overhaul and Shibu suggestions and other changes #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EzioDCL
wants to merge
17
commits into
main
Choose a base branch
from
shibu-layout-home
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
af72b7f
Improvements
eziomenutti a9d20f6
Merge branch 'main' into shibu-layout-home
EzioDCL 160c931
fix: apply prettier formatting to LearnPage and SceneList components
nearnshaw 5736165
Merge branch 'main' into shibu-layout-home
nearnshaw e0aabf2
upgrade SDK version
nearnshaw b524844
fix: update package-lock.json to sync @dcl/js-runtime to 7.20.3
eziomenutti 5d08b5c
update gird-list buttons
eziomenutti 99661b7
feat: add list view, sort/filter improvements to scenes tab
eziomenutti 5357077
Fix sorty by issues
eziomenutti 9b25b77
Fix Docs Links
eziomenutti 41ccead
Update
eziomenutti fb94aa6
update git ignore
eziomenutti 08eb082
Delete .claude/settings.local.json
EzioDCL 930175b
Merge branch 'main' into shibu-layout-home
EzioDCL c81a13a
Merge branch 'main' into shibu-layout-home
EzioDCL 0ef0237
Merge branch 'main' into shibu-layout-home
EzioDCL 636a224
Merge branch 'main' into shibu-layout-home
EzioDCL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(npm run:*)", | ||
| "Bash(grep -r \"MemoryRouter\\\\|initialEntries\" c:UsersezequDocumentsGitHubcreator-hubpackagescreator-hubrenderersrc --include=*.tsx --include=*.ts)", | ||
| "Bash(gh api:*)", | ||
| "WebFetch(domain:api.github.com)", | ||
| "WebFetch(domain:raw.githubusercontent.com)", | ||
| "Bash(curl -s \"https://raw.githubusercontent.com/decentraland/creator-hub/test-new-layout-home/packages/creator-hub/renderer/src/components/LearnPage/index.ts\" -o \"C:/Users/ezequ/AppData/Local/Temp/LearnPage_index.ts\")", | ||
| "Bash(curl -s \"https://raw.githubusercontent.com/decentraland/creator-hub/test-new-layout-home/packages/creator-hub/renderer/src/components/LearnPage/images/docs-icon.svg\" -o \"C:/Users/ezequ/AppData/Local/Temp/LearnPage_docs-icon.svg\")", | ||
| "Bash(curl -s \"https://raw.githubusercontent.com/decentraland/creator-hub/test-new-layout-home/packages/creator-hub/renderer/src/components/LearnPage/images/link-icon.svg\" -o \"C:/Users/ezequ/AppData/Local/Temp/LearnPage_link-icon.svg\")", | ||
| "Bash(curl -s \"https://raw.githubusercontent.com/decentraland/creator-hub/test-new-layout-home/packages/creator-hub/renderer/src/components/LearnPage/component.tsx\")", | ||
| "Bash(curl -s \"https://raw.githubusercontent.com/decentraland/creator-hub/test-new-layout-home/packages/creator-hub/renderer/src/components/LearnPage/styles.css\")", | ||
| "Bash(git ls-tree:*)", | ||
| "Bash(git checkout:*)", | ||
| "Bash(npx tsc:*)", | ||
| "Bash(find packages/creator-hub/renderer/src/components/Container -name *.tsx)", | ||
| "Bash(xargs grep:*)", | ||
| "Bash(gh pr:*)", | ||
| "Bash(npm install:*)", | ||
| "Bash(git add:*)", | ||
| "Bash(git commit:*)", | ||
| "Bash(grep -E \"\\\\.\\(ts|js\\)$\")", | ||
| "Bash(find /c/Users/ezequ/Documents/GitHub/creator-hub -type f -name *.ts -path */lib/deploy*)", | ||
| "Bash(grep -r \"api/files\\\\|/files\" /c/Users/ezequ/Documents/GitHub/creator-hub --include=*.ts --include=*.tsx)", | ||
| "Bash(find /c/Users/ezequ/Documents/GitHub/creator-hub -type f -name *.ts -path */services/* -o -name *fs* -path */services/*)", | ||
| "Bash(grep -r \"publishScene\\\\|editor.publish\" /c/Users/ezequ/Documents/GitHub/creator-hub/packages/creator-hub --include=*.ts --include=*.tsx)", | ||
| "Bash(find /c/Users/ezequ/Documents/GitHub/creator-hub -type f -name *file* -path */modules/*)", | ||
| "Bash(git log:*)", | ||
| "Bash(python3 -c \"import json; data=json.load\\(open\\(''packages/creator-hub/renderer/src/modules/store/translation/locales/en.json''\\)\\); print\\(json.dumps\\(data.get\\(''scene_list'', {}\\).get\\(''sort'', {}\\), indent=2\\)\\)\")", | ||
| "Bash(node -e \"const d=require\\(''./packages/creator-hub/renderer/src/modules/store/translation/locales/en.json''\\); console.log\\(JSON.stringify\\(d.scene_list?.sort, null, 2\\)\\)\")", | ||
| "Bash(node -e \"const d=require\\(''./packages/creator-hub/renderer/src/modules/store/translation/locales/en.json''\\); console.log\\(JSON.stringify\\(d.scene_list?.table, null, 2\\)\\)\")", | ||
| "Bash(python3 -c \":*)", | ||
| "Bash(grep ^ignore$)", | ||
| "Bash(du -sh \"/c/Users/ezequ/AppData/Roaming/creator-hub/Scenes/Versus MK/assets/\"*/)", | ||
| "Bash(du -sh \"/c/Users/ezequ/AppData/Roaming/creator-hub/Scenes/Versus MK/assets/scene/\"*/)", | ||
| "Bash(xargs stat:*)", | ||
| "Read(//c/Users/ezequ/Documents/GitHub/creator-hub/{sum+=$1} END {print \"\"\"\"\"\"\"\"Total bytes:\"\"\"\"\"\"\"\", sum, \"\"\"\"\"\"\"\"= MB:\"\"\"\"\"\"\"\", sum/1024/**)", | ||
| "Bash(find '/c/Users/ezequ/AppData/Roaming/creator-hub/Scenes/Versus MK/assets' -type f -exec wc -c {})", | ||
| "Bash(2)", | ||
| "Read(//c/Users/ezequ/Documents/GitHub/creator-hub/{sum+=$1} END {print \"\"\"\"\"\"\"\"Total bytes:\"\"\"\"\"\"\"\", sum, \"\"\"\"\"\"\"\" = MB:\"\"\"\"\"\"\"\", sum/1024/**)", | ||
| "Bash(while read:*)", | ||
| "Bash(do node:*)", | ||
| "Bash(done)", | ||
| "Read(//c/Users/ezequ/Documents/GitHub/creator-hub/{sum+=$1} END {print \"\"\"\"\"\"\"\"Total:\"\"\"\"\"\"\"\", sum, \"\"\"\"\"\"\"\"bytes =\"\"\"\"\"\"\"\", sum/1024/**)", | ||
| "Bash(node -e \":*)", | ||
| "Bash(node -e \"const path=require\\(''path''\\);const fs=require\\(''fs''\\);function s\\(d\\){let t=0;try{const e=fs.readdirSync\\(d\\);for\\(const n of e\\){const f=path.join\\(d,n\\);const st=fs.statSync\\(f\\);if\\(st.isDirectory\\(\\)\\)t+=s\\(f\\);else t+=st.size;}}catch\\(e\\){console.error\\(''err'',d,e.message\\);}return t;}const p=''C:/Users/ezequ/AppData/Roaming/creator-hub/Scenes/Versus MK/assets'';console.log\\(s\\(p\\)/1024/1024,''MB''\\);\")", | ||
| "Bash(grep -n \"contextBridge\\\\|exposeInMainWorld\" c:/Users/ezequ/Documents/GitHub/creator-hub/packages/creator-hub/preload/src/*.ts)", | ||
| "Bash(grep -rn \"contextBridge\\\\|exposeInMainWorld\" c:/Users/ezequ/Documents/GitHub/creator-hub/packages/creator-hub/preload/ --include=*.ts)", | ||
| "Bash(find c:/Users/ezequ/Documents/GitHub/creator-hub/node_modules/@dcl/sdk-commands/dist -name *.js)", | ||
| "Bash(find c:/Users/ezequ/Documents/GitHub/creator-hub -path */sdk-commands/dist* -name *.js)" | ||
| ] | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,3 +27,7 @@ | |
| .Filters .right > span { | ||
| margin: 0 8px 0 0; | ||
| } | ||
|
|
||
| .Filters .right .SearchInput { | ||
| margin-left: 24px; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't upload the
settings.local.json. do you mind removing this file from the PR and adding it to the.gitignore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!