feat: dynamic lights - #1049
Merged
Merged
Conversation
Deploying js-sdk-toolchain with
|
| Latest commit: |
a101149
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ceb6cad.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-dynamic-lights.js-sdk-toolchain.pages.dev |
Contributor
Test this pull request
|
pravusjif
approved these changes
Jan 27, 2025
pravusjif
left a comment
pravusjif
left a comment
Member
There was a problem hiding this comment.
Remember to update the protocol to point to @next after your protocol branch is merged and before merging this branch.
Member
|
And also of course fix the CI lint (running |
gonpombo8
reviewed
Feb 10, 2025
…ocol to experimental branch
AlejandroAlvarezMelucciDCL
force-pushed
the
feat/dynamic-lights
branch
from
February 14, 2025 19:22
76b8eef to
540fae2
Compare
gonpombo8
approved these changes
Feb 18, 2025
pravusjif
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Updated Makefile to improve the command update-protocol. Updated protocol to experimental branch * Added LigthSource tests and helper method * Regenerated playground-assets.api.md * Updated snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Protocol PR: decentraland/protocol#234
E@ PR: decentraland/unity-explorer#3113