Skip to content

Feat/auto import assets #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejandralevy merged 5 commits into from
Jul 8, 2025
Merged

Feat/auto import assets #1152

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4557db9
feat: upload file to assets
alejandralevy Jul 7, 2025
7f33cb0
feat: Set correct route on import
alejandralevy Jul 7, 2025
dea75b6
feat: Add missing extesion to file name
alejandralevy Jul 7, 2025
fc71081
feat: Reorder imports
alejandralevy Jul 7, 2025
8d91d90
feat: add missing deps on useefect
alejandralevy Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 34 additions & 19 deletions packages/@dcl/inspector/src/components/ui/FileUploadField/FileUploadField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import { VscFolderOpened as FolderIcon } from 'react-icons/vsc'

import { selectAssetCatalog, selectUploadFile, updateUploadFile } from '../../../redux/app'
import { useAppDispatch, useAppSelector } from '../../../redux/hooks'
import { importAsset } from '../../../redux/data-layer'
import { DropTypesEnum, LocalAssetDrop, getNode } from '../../../lib/sdk/drag-drop'
import { EXTENSIONS, withAssetDir } from '../../../lib/data-layer/host/fs-utils'
import { DIRECTORY, EXTENSIONS, withAssetDir } from '../../../lib/data-layer/host/fs-utils'

import { buildAssetPath, convertAssetToBinary, processAssets } from '../../ImportAsset/utils'
import { isModel } from '../../EntityInspector/GltfInspector/utils'
import { isAudio } from '../../EntityInspector/AudioSourceInspector/utils'
import { isModel as isTexture } from '../../EntityInspector/MaterialInspector/Texture/utils'
Expand Down Expand Up @@ -126,24 +128,6 @@ const FileUploadField: React.FC<Props> = ({
inputRef.current?.click()
}, [inputRef])

const handleChange = useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
const file = event.target.files?.[0]
if (file && isValidFileName(file.name)) {
setDropError(false)
const newUploadFile = { ...uploadFile }
newUploadFile[id.current] = file
dispatch(updateUploadFile(newUploadFile))
} else {
setDropError(true)
}

// Clear input value
if (inputRef.current) inputRef.current.value = ''
},
[inputRef, setPath, setDropError]
)

const handleChangeTextField = useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
const { value } = event.target
Expand All @@ -161,6 +145,37 @@ const FileUploadField: React.FC<Props> = ({
[addBase, setPath, setDropError, acceptURLs, onChange]
)

const handleChange = useCallback(
async (event: React.ChangeEvent<HTMLInputElement>) => {
const file = event.target.files?.[0]
if (file && isValidFileName(file.name)) {
setDropError(false)
const [newAsset] = await processAssets([file])
const basePath = withAssetDir(DIRECTORY.SCENE)
const assetPackageName = buildAssetPath(newAsset)
const content = await convertAssetToBinary(newAsset)
const newUploadFile = { ...uploadFile }
newUploadFile[id.current] = file
const assetPath = `${basePath}/${assetPackageName}/${newAsset.name}.${newAsset.extension}`
dispatch(
importAsset({
content,
basePath,
assetPackageName,
reload: true
})
)
dispatch(updateUploadFile(newUploadFile))
setPath(assetPath)
onDrop && onDrop(assetPath)
} else {
setDropError(true)
}
if (inputRef.current) inputRef.current.value = ''
},
[inputRef, setPath, setDropError, uploadFile, onDrop]
)

const hasError = useMemo(() => {
return error || dropError
}, [error, dropError])
Expand Down
Loading