chore: stringify console log arguments - #1185
Closed
pravusjif wants to merge 2 commits into
Closed
Conversation
Deploying js-sdk-toolchain with
|
| Latest commit: |
a45580e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://033d8293.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://chore-stringify-console-log.js-sdk-toolchain.pages.dev |
Contributor
Test this pull request
|
Member
Author
|
Will do the same on Explorer side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added console log wrapper to stringify arguments, to avoid printing
Object objecton those cases.With this change, if a scene code calls
console.log(whateverObject)it doesn't printObject objectanymore.When putting the arg in an inline string, it will still need the
JSON.Stringify()because as as soon as the object is included as:'print object: ${whateverObject}'it gets automatically casted to String by Javascript and Javascript always stringifies objects as "Object object".