Skip to content

[DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs - #1525

Draft
cyaiox wants to merge 1 commit into
stack/07-boot-host-contractfrom
stack/08-simplification
Draft

[DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs#1525
cyaiox wants to merge 1 commit into
stack/07-boot-host-contractfrom
stack/08-simplification

Conversation

@cyaiox

@cyaiox cyaiox commented Aug 5, 2026

Copy link
Copy Markdown
Member

Post-completion simplification pass over the network layer, behavior-
preserving (wire goldens byte-identical, red suite unchanged at
exactly #11/#13, all gates green). Net -95 lines:

  • runtime-context.ts folded back into addSyncTransport (its planned
    second consumer never materialized; two atoms + one kickoff = 4
    inline lines)
  • chunkCrdtMessages deleted by executing its own ponytail marker:
    test call sites now compose packChunks(readMessages(...)) directly
  • server/index.ts: LIVEKIT_MAX_SIZE re-export shim,
    findExistingNetworkEntity wrapper (zero external callers), and
    commented-out logs removed
  • getMessagesToSend() folded into its single call site (splice(0)
    idiom already used by the comms buffer)
  • Room: unused _engine ctor param dropped, binaryMessageBus typed
    (was any), fields collapsed to parameter properties;
    RESERVED_MESSAGE_PREFIX and fixTransformParent de-exported
  • ~30 comments that restated the line below them removed; harness
    drops its unread raw 'delivered' array from the returned object
  • host-conformance.md: stale line references repointed, stray
    authoring artifact removed

Deliberately kept (checked, load-bearing): the two isRoomReady sites
(disjoint orderings), the dump accumulator's three fields, both
players exports, every sdk-commands defensive branch.

Claude-Session: https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU


📚 Stack (splits #1505 — merge top-down within each stack)

Network layer (each PR is one self-contained, independently-green commit):

  1. test(sdk): characterization baseline for the network layer refactor #1518 test harness — characterization baseline + red defect suite (this stack's root)
  2. [DO NOT MERGE] refactor(sdk): network layer foundations — break cycles, single isServer, logging discipline #1519 foundations — cycle break, single isServer, logging discipline
  3. [DO NOT MERGE] feat(sdk): hydration FSM — deterministic late-join and reconnect convergence #1520 hydration FSM — late-join/reconnect correctness
  4. [DO NOT MERGE] feat(sdk): default-deny server validation, fixed correction path, O(1) entity lookup #1521 validator — default-deny, correction path, entity index
  5. [DO NOT MERGE] refactor(sdk): unify CRDT codec into a parse-once pipeline #1522 codec — parse-once pipeline (wire goldens byte-identical)
  6. [DO NOT MERGE] feat(sdk): clients target the authoritative server; registry collisions; players dedupe #1523 topology — targeted sends, registry collisions, players dedupe
  7. [DO NOT MERGE] refactor(sdk): parameterize network boot, document the host contract #1524 boot + host-conformance doc
  8. [DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs #1525 simplification sweep (−95 lines)

sdk-commands (independent of the stack above):

After a parent squash-merges, the child needs git rebase --onto origin/auth-server <old-parent> <child> — ping the session and it gets restacked.

Post-completion simplification pass over the network layer, behavior-
preserving (wire goldens byte-identical, red suite unchanged at
exactly #11/#13, all gates green). Net -95 lines:

- runtime-context.ts folded back into addSyncTransport (its planned
  second consumer never materialized; two atoms + one kickoff = 4
  inline lines)
- chunkCrdtMessages deleted by executing its own ponytail marker:
  test call sites now compose packChunks(readMessages(...)) directly
- server/index.ts: LIVEKIT_MAX_SIZE re-export shim,
  findExistingNetworkEntity wrapper (zero external callers), and
  commented-out logs removed
- getMessagesToSend() folded into its single call site (splice(0)
  idiom already used by the comms buffer)
- Room: unused _engine ctor param dropped, binaryMessageBus typed
  (was any), fields collapsed to parameter properties;
  RESERVED_MESSAGE_PREFIX and fixTransformParent de-exported
- ~30 comments that restated the line below them removed; harness
  drops its unread raw 'delivered' array from the returned object
- host-conformance.md: stale line references repointed, stray
  authoring artifact removed

Deliberately kept (checked, load-bearing): the two isRoomReady sites
(disjoint orderings), the dump accumulator's three fields, both
players exports, every sdk-commands defensive branch.

Claude-Session: https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/stack/08-simplification/dcl-sdk-7.25.1-31013706532.commit-dd80870.tgz"
  • The @dcl/js-runtime package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/stack/08-simplification/@dcl/js-runtime/dcl-js-runtime-7.25.1-31013706532.commit-dd80870.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/stack/08-simplification/dcl-sdk-commands-7.25.1-31013706532.commit-dd80870.tgz"
    npx $SDK_COMMANDS init
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/stack/08-simplification-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=stack/08-simplification

@cyaiox cyaiox changed the title refactor(sdk): ponytail sweep — delete what the refactor no longer needs [DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs Aug 5, 2026
@cyaiox
cyaiox marked this pull request as draft August 5, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant