[DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs - #1525
Draft
cyaiox wants to merge 1 commit into
Draft
[DO NOT MERGE] refactor(sdk): ponytail sweep — delete what the refactor no longer needs#1525cyaiox wants to merge 1 commit into
cyaiox wants to merge 1 commit into
Conversation
Post-completion simplification pass over the network layer, behavior- preserving (wire goldens byte-identical, red suite unchanged at exactly #11/#13, all gates green). Net -95 lines: - runtime-context.ts folded back into addSyncTransport (its planned second consumer never materialized; two atoms + one kickoff = 4 inline lines) - chunkCrdtMessages deleted by executing its own ponytail marker: test call sites now compose packChunks(readMessages(...)) directly - server/index.ts: LIVEKIT_MAX_SIZE re-export shim, findExistingNetworkEntity wrapper (zero external callers), and commented-out logs removed - getMessagesToSend() folded into its single call site (splice(0) idiom already used by the comms buffer) - Room: unused _engine ctor param dropped, binaryMessageBus typed (was any), fields collapsed to parameter properties; RESERVED_MESSAGE_PREFIX and fixTransformParent de-exported - ~30 comments that restated the line below them removed; harness drops its unread raw 'delivered' array from the returned object - host-conformance.md: stale line references repointed, stray authoring artifact removed Deliberately kept (checked, load-bearing): the two isRoomReady sites (disjoint orderings), the dump accumulator's three fields, both players exports, every sdk-commands defensive branch. Claude-Session: https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU
This was referenced Aug 5, 2026
Draft
Contributor
Test this pull request
|
cyaiox
marked this pull request as draft
August 5, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-completion simplification pass over the network layer, behavior-
preserving (wire goldens byte-identical, red suite unchanged at
exactly #11/#13, all gates green). Net -95 lines:
second consumer never materialized; two atoms + one kickoff = 4
inline lines)
test call sites now compose packChunks(readMessages(...)) directly
findExistingNetworkEntity wrapper (zero external callers), and
commented-out logs removed
idiom already used by the comms buffer)
(was any), fields collapsed to parameter properties;
RESERVED_MESSAGE_PREFIX and fixTransformParent de-exported
drops its unread raw 'delivered' array from the returned object
authoring artifact removed
Deliberately kept (checked, load-bearing): the two isRoomReady sites
(disjoint orderings), the dump accumulator's three fields, both
players exports, every sdk-commands defensive branch.
Claude-Session: https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kzo6zwrn1CA79S4RN1dgsU
📚 Stack (splits #1505 — merge top-down within each stack)
Network layer (each PR is one self-contained, independently-green commit):
sdk-commands (independent of the stack above):
After a parent squash-merges, the child needs
git rebase --onto origin/auth-server <old-parent> <child>— ping the session and it gets restacked.